Bug 32108 - Allow custom memory allocation control for 2 classes of the platform directory in WebCore
Summary: Allow custom memory allocation control for 2 classes of the platform director...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-03 01:53 PST by Zoltan Horvath
Modified: 2009-12-04 02:46 PST (History)
2 users (show)

See Also:


Attachments
Patch (2.17 KB, patch)
2009-12-03 01:53 PST, Zoltan Horvath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2009-12-03 01:53:53 PST
Created attachment 44217 [details]
Patch

Inherits the following class from Noncopyable because it is instantiated
by 'new' and no need to be copyable:

class/struct name         - instantiated at: WebCore/'location'

class SharedTimer         - (its child class) workers/WorkerRunLoop.cpp:91

Inherits the following class from FastAllocBase because it is
instantiated by 'new':

class TransformOperations - rendering/style/RenderStyle.h:1175
Comment 1 WebKit Review Bot 2009-12-03 01:55:00 PST
Attachment 44217 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/SharedTimer.h:34:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1
Comment 2 Zoltan Horvath 2009-12-03 02:02:32 PST
Dear Review Bot,

every lines are indented inside that Namespace.

Please think about it! :-)
Comment 3 Adam Barth 2009-12-03 09:44:04 PST
Sorry for the style-queue false positive.  We've done one round of tuning on that warning to reduce false positives.  It sounds like we need to do another.  Thank you for your patience.
Comment 4 Zoltan Horvath 2009-12-04 00:18:45 PST
It's okay. I'm happy that I can test it!
Comment 5 Zoltan Horvath 2009-12-04 00:38:59 PST
Comment on attachment 44217 [details]
Patch

Clearing flags on attachment: 44217

Committed r51687: <http://trac.webkit.org/changeset/51687>
Comment 6 Zoltan Horvath 2009-12-04 00:39:07 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Zoltan Horvath 2009-12-04 02:46:04 PST
Rolled out in r51688 because build error on Mac and unrolled out in r51690 (build fix added).