Bug 32108 – Allow custom memory allocation control for 2 classes of the platform directory in WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Zoltan Horvath]

Created attachment 44217 [details]
Patch

Inherits the following class from Noncopyable because it is instantiated
by 'new' and no need to be copyable:

class/struct name         - instantiated at: WebCore/'location'

class SharedTimer         - (its child class) workers/WorkerRunLoop.cpp:91

Inherits the following class from FastAllocBase because it is
instantiated by 'new':

class TransformOperations - rendering/style/RenderStyle.h:1175

[WebKit Review Bot]

Attachment 44217 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/SharedTimer.h:34:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1

[Zoltan Horvath]

Dear Review Bot,

every lines are indented inside that Namespace.

Please think about it! :-)

[Adam Barth]

Sorry for the style-queue false positive.  We've done one round of tuning on that warning to reduce false positives.  It sounds like we need to do another.  Thank you for your patience.

[Zoltan Horvath]

It's okay. I'm happy that I can test it!

[Zoltan Horvath]

Comment on attachment 44217 [details]
Patch

Clearing flags on attachment: 44217

Committed r51687: <http://trac.webkit.org/changeset/51687>

[Zoltan Horvath]

All reviewed patches have been landed.  Closing bug.

[Zoltan Horvath]

Rolled out in r51688 because build error on Mac and unrolled out in r51690 (build fix added).