WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
32096
check-webkit-style is too noisy about namespace indenting issues.
https://bugs.webkit.org/show_bug.cgi?id=32096
Summary
check-webkit-style is too noisy about namespace indenting issues.
David Levin
Reported
2009-12-02 17:06:49 PST
With this fixed, it will only flag the first instance of a namespace indent issue. This will eliminate the error from appearing when people modify a file (which seems ok) unless they change the first line in a namespace. It also cuts down on the noise generate by improper indenting so that the output from check-webkit-style is more readable.
Attachments
check-webkit-style is too noisy about namespace indenting issues.
(10.19 KB, patch)
2009-12-02 17:18 PST
,
David Levin
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Levin
Comment 1
2009-12-02 17:18:27 PST
Created
attachment 44195
[details]
check-webkit-style is too noisy about namespace indenting issues.
Adam Barth
Comment 2
2009-12-02 21:01:39 PST
Comment on
attachment 44195
[details]
check-webkit-style is too noisy about namespace indenting issues. Awesome. Thanks for fixing this.
WebKit Commit Bot
Comment 3
2009-12-02 21:09:07 PST
Comment on
attachment 44195
[details]
check-webkit-style is too noisy about namespace indenting issues. Clearing flags on attachment: 44195 Committed
r51619
: <
http://trac.webkit.org/changeset/51619
>
WebKit Commit Bot
Comment 4
2009-12-02 21:09:11 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug