Bug 32096 - check-webkit-style is too noisy about namespace indenting issues.
Summary: check-webkit-style is too noisy about namespace indenting issues.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-02 17:06 PST by David Levin
Modified: 2009-12-02 21:09 PST (History)
3 users (show)

See Also:

Attachments
check-webkit-style is too noisy about namespace indenting issues. (10.19 KB, patch)
2009-12-02 17:18 PST, David Levin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2009-12-02 17:06:49 PST 
With this fixed, it will only flag the first instance of a namespace indent issue.

This will eliminate the error from appearing when people modify a file (which seems ok) unless they change the first line in a namespace.

It also cuts down on the noise generate by improper indenting so that the output from check-webkit-style is more readable.
Comment 1 David Levin 2009-12-02 17:18:27 PST 
Created attachment 44195 [details]
check-webkit-style is too noisy about namespace indenting issues.
Comment 2 Adam Barth 2009-12-02 21:01:39 PST 
Comment on attachment 44195 [details]
check-webkit-style is too noisy about namespace indenting issues.

Awesome.  Thanks for fixing this.
Comment 3 WebKit Commit Bot 2009-12-02 21:09:07 PST 
Comment on attachment 44195 [details]
check-webkit-style is too noisy about namespace indenting issues.

Clearing flags on attachment: 44195

Committed r51619: <http://trac.webkit.org/changeset/51619>
Comment 4 WebKit Commit Bot 2009-12-02 21:09:11 PST 
All reviewed patches have been landed.  Closing bug.