Bug 32094 - [V8] Attributes and NamedNodeMaps aren't tracked correctly and may be prematurely garbage-collected.
Summary: [V8] Attributes and NamedNodeMaps aren't tracked correctly and may be prematu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-02 15:03 PST by Dimitri Glazkov (Google)
Modified: 2009-12-03 08:59 PST (History)
6 users (show)

See Also:


Attachments
WIP: Improve V8 bindings attribute story (7.64 KB, patch)
2009-12-02 15:12 PST, Dimitri Glazkov (Google)
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-12-02 15:03:30 PST
I started looking at it after researching the QualifiedName crash (http://crbug.com/27068). Turns out, there's a test for that:

http://trac.webkit.org/changeset/48769

... and Chromium was failing it. So fix is coming up.
Comment 1 Dimitri Glazkov (Google) 2009-12-02 15:12:09 PST
Created attachment 44187 [details]
WIP: Improve V8 bindings attribute story
Comment 3 WebKit Review Bot 2009-12-02 21:12:25 PST
style-queue ran check-webkit-style on attachment 44187 [details] without any errors.
Comment 4 Adam Barth 2009-12-02 21:25:05 PST
Comment on attachment 44187 [details]
WIP: Improve V8 bindings attribute story

Ok.  This stuff is pretty subtle, but I'm glad it fixes a LayoutTest!
Comment 5 Dimitri Glazkov (Google) 2009-12-03 08:59:11 PST
Landed as http://trac.webkit.org/changeset/51638.