Bug 32079 – Undo should not affect elements that are not editable

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Enrica Casucci]

If an element changes from editable to non-editable, all undo commands that apply to it and its descendant should be ignored.
Same goes for redo.

[Enrica Casucci]

Created attachment 44170 [details]
patch

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 44170 [details] without any errors.

[Adele Peterson]

Comment on attachment 44170 [details]
patch

Are there cases where the parent isn't editable, and its not attached, where we would want to allow the AppendNodeCommand?

>  void AppendNodeCommand::doApply()
>  {
> +    if (!m_parent->isContentEditable() && m_parent->attached())
> +        return;
> +        
>      ExceptionCode ec;
>      m_parent->appendChild(m_node.get(), ec);
>  }

[Enrica Casucci]

(In reply to comment #3)
> (From update of attachment 44170 [details])
> Are there cases where the parent isn't editable, and its not attached, where we
> would want to allow the AppendNodeCommand?
> 
> >  void AppendNodeCommand::doApply()
> >  {
> > +    if (!m_parent->isContentEditable() && m_parent->attached())
> > +        return;
> > +        
> >      ExceptionCode ec;
> >      m_parent->appendChild(m_node.get(), ec);
> >  }

I don't think so. Look at the ASSERT in the constructor.
    ASSERT(m_parent->isContentEditable() || !m_parent->attached());

[Adele Peterson]

ok, makes sense

[Enrica Casucci]

Committed revision 51645.