Bug 32076 - Web Inspector: Simplify the settings support in inspector controller.
: Web Inspector: Simplify the settings support in inspector controller.
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Pavel Feldman
Depends on:
  Show dependency treegraph
Reported: 2009-12-02 11:04 PST by Pavel Feldman
Modified: 2009-12-03 04:47 PST (History)
4 users (show)

See Also:

[PATCH] Proposed change (55.84 KB, patch)
2009-12-02 12:54 PST, Pavel Feldman
timothy: review+
pfeldman: commit‑queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-12-02 11:04:09 PST
Looks like majority of the settings are going to be related to the frontend. i was thinking that we could leave only string name/value pairs as settings for inspector controller and serialize rest into json on the frontend side. That way we have nice structured settings with no custom serializers in frontend, have basic support for name/value settings on inspector controller side and have no native serialization code for different platforms.
Comment 1 Pavel Feldman 2009-12-02 12:54:10 PST
Created attachment 44174 [details]
[PATCH] Proposed change

This change makes everything String. It supports reading boolean properties from the legacy store in order to properly handle debugger/profiles/resources enabled state. However, it does not read numbers properly - users will lose preferred attached height once migrated (only once). I think it is reasonable compromise given that all supporting code can be deleted...
Comment 2 Pavel Feldman 2009-12-02 14:02:07 PST
Comment on attachment 44174 [details]
[PATCH] Proposed change

I'd like to land this manually after I test gtk build.
Comment 3 Pavel Feldman 2009-12-03 04:47:29 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	A	LayoutTests/inspector/settings-set-get-expected.txt
	A	LayoutTests/inspector/settings-set-get.html
	M	WebCore/ChangeLog
	M	WebCore/WebCore.Inspector.exp
	M	WebCore/bindings/js/JSInspectorFrontendHostCustom.cpp
	M	WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp
	M	WebCore/inspector/InspectorClient.h
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorController.h
	M	WebCore/inspector/InspectorFrontendHost.cpp
	M	WebCore/inspector/InspectorFrontendHost.h
	M	WebCore/inspector/InspectorFrontendHost.idl
	M	WebCore/loader/EmptyClients.h
	M	WebKit/cf/ChangeLog
	M	WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/src/InspectorClientImpl.cpp
	M	WebKit/chromium/src/InspectorClientImpl.h
	M	WebKit/gtk/ChangeLog
	M	WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp
	M	WebKit/gtk/WebCoreSupport/InspectorClientGtk.h
	M	WebKit/haiku/ChangeLog
	M	WebKit/haiku/WebCoreSupport/InspectorClientHaiku.cpp
	M	WebKit/haiku/WebCoreSupport/InspectorClientHaiku.h
	M	WebKit/mac/ChangeLog
	M	WebKit/mac/WebCoreSupport/WebInspectorClient.h
	M	WebKit/mac/WebCoreSupport/WebInspectorClient.mm
	M	WebKit/qt/ChangeLog
	M	WebKit/qt/WebCoreSupport/InspectorClientQt.cpp
	M	WebKit/qt/WebCoreSupport/InspectorClientQt.h
	M	WebKit/win/ChangeLog
	M	WebKit/win/WebCoreSupport/WebInspectorClient.cpp
	M	WebKit/win/WebCoreSupport/WebInspectorClient.h
	M	WebKit/wx/ChangeLog
	M	WebKit/wx/WebKitSupport/InspectorClientWx.cpp
	M	WebKit/wx/WebKitSupport/InspectorClientWx.h
Committed r51631