Bug 32066 – [Chromium] Add enable geolocation flag to WebCore::Settings for Chromium

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jonathan Dixon]

In the Chromium port, the geolocation implementation will be ready for testing at different times on different platforms. Further, testing can commence before final UI and feature completion.
To ease integration, we need run time control of whether geolocation is enabled, to allow testing (e.g. in the dev channel) without requiring a complete rebuild.

This flag is not intended to be revealed in the UI. (e.g. on chromium it will be a command line flag available during the development cycle only)
When the flag is off, the navigator.geolocation object should not be set, indicating the browser has no geolocation support.

The ENABLE(GEOLOCATION) compile time flag is still required to completely compile out support for those platforms that do not require it.

[Jonathan Dixon]

Created attachment 44146 [details]
Patch 1 for Bug 32066

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 44146 [details] without any errors.

[Jonathan Dixon]

Created attachment 44150 [details]
Patch 2 for Bug 32066

Updated with comments from colleague

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 44150 [details] without any errors.

[Jonathan Dixon]

Would you be able to look at this Eric, or suggest someone else to?

[Dimitri Glazkov (Google)]

Comment on attachment 44150 [details]
Patch 2 for Bug 32066

> +    , m_geolocationEnabled(true)

Is the case for other ports? Do we need to plumb this through for WebKit/mac&win?

[Jonathan Dixon]

(In reply to comment #6)
> (From update of attachment 44150 [details])
> > +    , m_geolocationEnabled(true)
> 
> Is the case for other ports? Do we need to plumb this through for
> WebKit/mac&win?

The intention is in the "normal case" a port either has no support for the feature, so does not define ENABLE_GEOLOCATION, or has full support, in which case this flag can default to true -- i.e. equivalent to the existing situation without the existence of this flag, and without plumbing in calls to it.
(It also happens that at the current time no port has ENABLE_GEOLOCATION defined, so plumbing it would have no effect anyway)

I'm very happy to explain this in code comments some place, but not sure where is the best location for it?

[Jonathan Dixon]

Created attachment 44254 [details]
Patch 3 for Bug 32066

TODO => FIXME

[Dimitri Glazkov (Google)]

Comment on attachment 44254 [details]
Patch 3 for Bug 32066

r=me.

[Eric Seidel (no email)]

Seems a little strange to have two ways to enable Geolocation, but I'm also not sure I have anything better to suggest.  This isn't the first feature for which we have a runtime switch, certainly.

[WebKit Commit Bot]

Comment on attachment 44254 [details]
Patch 3 for Bug 32066

Clearing flags on attachment: 44254

Committed r51660: <http://trac.webkit.org/changeset/51660>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.