Bug 32060 - Remove unnecessary reference to ScriptObjectQuarantine
Summary: Remove unnecessary reference to ScriptObjectQuarantine
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-02 01:48 PST by Yury Semikhatsky
Modified: 2009-12-02 09:52 PST (History)
3 users (show)

See Also:


Attachments
patch (1.33 KB, patch)
2009-12-02 01:52 PST, Yury Semikhatsky
pfeldman: review-
Details | Formatted Diff | Diff
patch removing ScriptObjectQuarantine as a whole (29.81 KB, patch)
2009-12-02 02:50 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
patch removing ScriptObjectQuarantine as a whole (3.23 KB, patch)
2009-12-02 04:57 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
patch removing ScriptObjectQuarantine as a whole (32.08 KB, patch)
2009-12-02 04:58 PST, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2009-12-02 01:48:36 PST
Remove unnecessary reference to ScriptObjectQuarantine from InspectorDatabaseResource.
Comment 1 Yury Semikhatsky 2009-12-02 01:52:49 PST
Created attachment 44135 [details]
patch
Comment 2 WebKit Review Bot 2009-12-02 01:57:23 PST
style-queue ran check-webkit-style on attachment 44135 [details] without any errors.
Comment 3 Pavel Feldman 2009-12-02 02:26:14 PST
Comment on attachment 44135 [details]
patch

Could you please remove ScriptObjectQuarantine as a whole? We don't need it anymore.
Comment 4 Yury Semikhatsky 2009-12-02 02:50:25 PST
Created attachment 44140 [details]
patch removing ScriptObjectQuarantine as a whole
Comment 5 WebKit Review Bot 2009-12-02 02:54:16 PST
style-queue ran check-webkit-style on attachment 44140 [details] without any errors.
Comment 6 Adam Barth 2009-12-02 02:59:06 PST
Yay!!!
Comment 7 Yury Semikhatsky 2009-12-02 04:57:23 PST
Created attachment 44141 [details]
patch removing ScriptObjectQuarantine as a whole
Comment 8 Yury Semikhatsky 2009-12-02 04:58:39 PST
Created attachment 44142 [details]
patch removing ScriptObjectQuarantine as a whole
Comment 9 WebKit Review Bot 2009-12-02 05:01:13 PST
Attachment 44142 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Skipping input 'WebCore/bindings/js/ScriptObjectQuarantine.h': Can't open for reading
Skipping input 'WebCore/bindings/js/ScriptObjectQuarantine.cpp': Can't open for reading
Skipping input 'WebCore/bindings/v8/ScriptObjectQuarantine.h': Can't open for reading
WebCore/bindings/js/ScriptValue.cpp:30:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Skipping input 'WebCore/bindings/v8/ScriptObjectQuarantine.cpp': Can't open for reading
Total errors found: 1
Comment 10 Pavel Feldman 2009-12-02 05:03:56 PST
Comment on attachment 44142 [details]
patch removing ScriptObjectQuarantine as a whole

Adam, I think this is not what you think.
Comment 11 Yury Semikhatsky 2009-12-02 05:12:58 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	D	WebCore/bindings/js/ScriptObjectQuarantine.cpp
	D	WebCore/bindings/js/ScriptObjectQuarantine.h
	D	WebCore/bindings/v8/ScriptObjectQuarantine.cpp
	D	WebCore/bindings/v8/ScriptObjectQuarantine.h
	M	WebCore/ChangeLog
	M	WebCore/GNUmakefile.am
	M	WebCore/WebCore.gypi
	M	WebCore/WebCore.pro
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	M	WebCore/WebCore.xcodeproj/project.pbxproj
	M	WebCore/WebCoreSources.bkl
	M	WebCore/bindings/js/JSBindingsAllInOne.cpp
	M	WebCore/bindings/js/ScriptValue.cpp
	M	WebCore/bindings/js/ScriptValue.h
	M	WebCore/bindings/v8/ScriptValue.h
	M	WebCore/inspector/ConsoleMessage.cpp
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorDatabaseResource.cpp
	M	WebCore/inspector/InspectorFrontend.cpp
Committed r51598
Comment 12 Adam Barth 2009-12-02 09:52:46 PST
> Adam, I think this is not what you think.

Oh, maybe not.  I got too excited.  :)