RESOLVED FIXED 32060
Remove unnecessary reference to ScriptObjectQuarantine 
https://bugs.webkit.org/show_bug.cgi?id=32060
Summary Remove unnecessary reference to ScriptObjectQuarantine
Yury Semikhatsky
Reported 2009-12-02 01:48:36 PST
Remove unnecessary reference to ScriptObjectQuarantine from InspectorDatabaseResource.
Attachments
patch (1.33 KB, patch)
2009-12-02 01:52 PST, Yury Semikhatsky 		pfeldman: review-
DetailsFormatted DiffDiff
patch removing ScriptObjectQuarantine as a whole (29.81 KB, patch)
2009-12-02 02:50 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
patch removing ScriptObjectQuarantine as a whole (3.23 KB, patch)
2009-12-02 04:57 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
patch removing ScriptObjectQuarantine as a whole (32.08 KB, patch)
2009-12-02 04:58 PST, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2009-12-02 01:52:49 PST
Created attachment 44135 [details] patch
WebKit Review Bot
Comment 2 2009-12-02 01:57:23 PST
style-queue ran check-webkit-style on attachment 44135 [details] without any errors.
Pavel Feldman
Comment 3 2009-12-02 02:26:14 PST
Comment on attachment 44135 [details] patch Could you please remove ScriptObjectQuarantine as a whole? We don't need it anymore.
Yury Semikhatsky
Comment 4 2009-12-02 02:50:25 PST
Created attachment 44140 [details] patch removing ScriptObjectQuarantine as a whole
WebKit Review Bot
Comment 5 2009-12-02 02:54:16 PST
style-queue ran check-webkit-style on attachment 44140 [details] without any errors.
Adam Barth
Comment 6 2009-12-02 02:59:06 PST
Yay!!!
Yury Semikhatsky
Comment 7 2009-12-02 04:57:23 PST
Created attachment 44141 [details] patch removing ScriptObjectQuarantine as a whole
Yury Semikhatsky
Comment 8 2009-12-02 04:58:39 PST
Created attachment 44142 [details] patch removing ScriptObjectQuarantine as a whole
WebKit Review Bot
Comment 9 2009-12-02 05:01:13 PST
Attachment 44142 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Skipping input 'WebCore/bindings/js/ScriptObjectQuarantine.h': Can't open for reading Skipping input 'WebCore/bindings/js/ScriptObjectQuarantine.cpp': Can't open for reading Skipping input 'WebCore/bindings/v8/ScriptObjectQuarantine.h': Can't open for reading WebCore/bindings/js/ScriptValue.cpp:30: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Skipping input 'WebCore/bindings/v8/ScriptObjectQuarantine.cpp': Can't open for reading Total errors found: 1
Pavel Feldman
Comment 10 2009-12-02 05:03:56 PST
Comment on attachment 44142 [details] patch removing ScriptObjectQuarantine as a whole Adam, I think this is not what you think.
Yury Semikhatsky
Comment 11 2009-12-02 05:12:58 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... D WebCore/bindings/js/ScriptObjectQuarantine.cpp D WebCore/bindings/js/ScriptObjectQuarantine.h D WebCore/bindings/v8/ScriptObjectQuarantine.cpp D WebCore/bindings/v8/ScriptObjectQuarantine.h M WebCore/ChangeLog M WebCore/GNUmakefile.am M WebCore/WebCore.gypi M WebCore/WebCore.pro M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/WebCore.xcodeproj/project.pbxproj M WebCore/WebCoreSources.bkl M WebCore/bindings/js/JSBindingsAllInOne.cpp M WebCore/bindings/js/ScriptValue.cpp M WebCore/bindings/js/ScriptValue.h M WebCore/bindings/v8/ScriptValue.h M WebCore/inspector/ConsoleMessage.cpp M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorDatabaseResource.cpp M WebCore/inspector/InspectorFrontend.cpp Committed r51598
Adam Barth
Comment 12 2009-12-02 09:52:46 PST
> Adam, I think this is not what you think. Oh, maybe not. I got too excited. :)
Note You need to log in before you can comment on or make changes to this bug.