Bug 32058 - pywebsocket should log a more friendly error.
Summary: pywebsocket should log a more friendly error.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P5 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-02 00:38 PST by Fumitoshi Ukai
Modified: 2010-01-21 22:11 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fumitoshi Ukai 2009-12-02 00:38:02 PST 
pywebsocket shows following log now:
[2009-12-01 22:43:55,992] [WARNING] root: mod_pywebsocket: web_socket_transfer_data raised exception: Traceback (most recent call last):
  File "/Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/WebKitTools/pywebsocket/mod_pywebsocket/dispatch.py", line 179, in transfer_data
    transfer_data_(request)
  File "<string>", line 38, in web_socket_transfer_data
  File "/Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/WebKitTools/pywebsocket/mod_pywebsocket/msgutil.py", line 52, in send_message
    request.connection.write('\x00' + message.encode('utf-8') + '\xff')
  File "WebKitTools/pywebsocket/mod_pywebsocket/standalone.py", line 118, in write
    return self._request_handler.wfile.write(data)
  File "/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/socket.py", line 262, in write
    self.flush()
  File "/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/socket.py", line 249, in flush
    self._sock.sendall(buffer)
  File "<string>", line 1, in sendall
error: (32, 'Broken pipe')

the server should log a more friendly error to indicate what happened rather than logging a backtrace.
Comment 1 Fumitoshi Ukai 2010-01-21 22:11:01 PST 
I believe this was fixed at pywebsocket 0.4.3 (webkit r51661)