Bug 32057 - [bzt] Implement status bubble view
Summary: [bzt] Implement status bubble view
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-02 00:30 PST by Adam Barth
Modified: 2009-12-02 01:12 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.11 KB, patch)
2009-12-02 00:34 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (4.21 KB, patch)
2009-12-02 00:55 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-12-02 00:30:49 PST
We need to show a compact representation of the queue statuses to avoid spamming the bug comments.
Comment 1 Adam Barth 2009-12-02 00:34:13 PST
Created attachment 44132 [details]
Patch
Comment 2 WebKit Review Bot 2009-12-02 00:35:58 PST
style-queue ran check-webkit-style on attachment 44132 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-02 00:39:56 PST
Comment on attachment 44132 [details]
Patch

 79             "Pass": "pass",
Doesn't the PEP say it should be:
"foo" : "bar"?

Please explain this chang ein your ChangeLog:
 1 <!DOCTYPE html>

Can you provide an example output in the bug for easier review?
Comment 4 Eric Seidel (no email) 2009-12-02 00:45:10 PST
Comment on attachment 44132 [details]
Patch

Why not do this all at the end?
 103         self._summary[attachment_id] = {}

make a temporary dictionary up front and assign it at the end.  Then less typing.

This line is kinda hard to aprse:
6             self._summary[attachment_id][self._queue_name_to_code(queue)] = self._status_to_code(statuses[0].message if statuses else None)

We're gonna end up sending a lot of status-bubble html... but we can fix that later.

I thought spaces don't matter anymore?
 <body>{% for key, value in queue_status.items %}
 34 <div class="status {{value}}" title="{{key}}: {{value}}">{{key}}</div>{% endfor %}
 35 </body>
Comment 5 Adam Barth 2009-12-02 00:50:38 PST
(In reply to comment #3)
> (From update of attachment 44132 [details])
>  79             "Pass": "pass",
> Doesn't the PEP say it should be:
> "foo" : "bar"?

I can't find this in the style guide.

> Can you provide an example output in the bug for easier review?

<!DOCTYPE html> 
<html> 
<head> 
<style> 
body {
    font-family: Verdana, sans-serif;
    margin: 0px;
    padding: 0px;
}
.status {
    display: block;
    float: left;
    margin: 1px;
    padding: 1px 2px;
    border-radius: 5px;
    border: 1px solid #AAA;
    font-size: 11px;
}
.pass {
    background-color: #8FDF5F;
    border: 1px solid #4F8530;
}
.fail {
    background-color: #E98080;
    border: 1px solid #A77272;
}
.pending {
    background-color: #FFFC6C;
    border: 1px solid #C5C56D;
}
</style> 
</head> 
<body> 
<div class="status fail" title="style: fail">style</div> 
</body> 
</html>
Comment 6 Adam Barth 2009-12-02 00:54:25 PST
> I thought spaces don't matter anymore?

They're to make the view-source beautiful.  :)
Comment 7 Adam Barth 2009-12-02 00:55:50 PST
Created attachment 44134 [details]
Patch
Comment 8 WebKit Review Bot 2009-12-02 00:56:29 PST
style-queue ran check-webkit-style on attachment 44134 [details] without any errors.
Comment 9 Eric Seidel (no email) 2009-12-02 00:57:44 PST
Comment on attachment 44134 [details]
Patch

Looks ok.
Comment 10 WebKit Commit Bot 2009-12-02 01:12:02 PST
Comment on attachment 44134 [details]
Patch

Clearing flags on attachment: 44134

Committed r51591: <http://trac.webkit.org/changeset/51591>
Comment 11 WebKit Commit Bot 2009-12-02 01:12:07 PST
All reviewed patches have been landed.  Closing bug.