WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
32022
check-webkit-style complains about #imports with / in them
https://bugs.webkit.org/show_bug.cgi?id=32022
Summary
check-webkit-style complains about #imports with / in them
Eric Seidel (no email)
Reported
2009-12-01 07:57:44 PST
check-webkit-style complains about #imports with / in them
https://bugs.webkit.org/show_bug.cgi?id=31915#c4
I expect it has special exclusion rules for #include, but that they're missing for #import in this case.
Attachments
Patch
(2.29 KB, patch)
2009-12-01 08:27 PST
,
Adam Barth
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2009-12-01 08:18:24 PST
Investigating.
Adam Barth
Comment 2
2009-12-01 08:27:49 PST
Created
attachment 44081
[details]
Patch
WebKit Review Bot
Comment 3
2009-12-01 08:28:43 PST
style-queue ran check-webkit-style on
attachment 44081
[details]
without any errors.
Eric Seidel (no email)
Comment 4
2009-12-01 08:30:40 PST
Comment on
attachment 44081
[details]
Patch I think I would have written that as: if match(r'\s*#\s*(include|import)', line): Otherwise it looks OK.
Adam Barth
Comment 5
2009-12-01 08:46:59 PST
Committed
r51541
: <
http://trac.webkit.org/changeset/51541
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug