Bug 32020 - [Chromium] Provide a way to get ScriptState for the inspected page
Summary: [Chromium] Provide a way to get ScriptState for the inspected page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-01 07:32 PST by Yury Semikhatsky
Modified: 2009-12-01 08:24 PST (History)
2 users (show)

See Also:


Attachments
patch (3.15 KB, patch)
2009-12-01 07:34 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
patch (3.16 KB, patch)
2009-12-01 07:36 PST, Yury Semikhatsky
abarth: review+
Details | Formatted Diff | Diff
patch addressing comments that I'm going to land (3.23 KB, patch)
2009-12-01 08:08 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2009-12-01 07:32:25 PST
InspectorController::didEvaluateForTestInFrontend needs to invoke a function in the inspected page main frame. Would be nice to be able to get ScriptState for the frame.
Comment 1 Yury Semikhatsky 2009-12-01 07:34:58 PST
Created attachment 44075 [details]
patch
Comment 2 WebKit Review Bot 2009-12-01 07:36:45 PST
Attachment 44075 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/ScriptController.cpp:360:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/v8/ScriptController.cpp:362:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/v8/ScriptController.h:51:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3
Comment 3 Yury Semikhatsky 2009-12-01 07:36:55 PST
Created attachment 44076 [details]
patch
Comment 4 WebKit Review Bot 2009-12-01 07:42:07 PST
Attachment 44076 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/ScriptController.h:51:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1
Comment 5 Adam Barth 2009-12-01 07:49:58 PST
Comment on attachment 44076 [details]
patch

Maybe we should call this mainWorldScriptState to be explicit?
Comment 6 Yury Semikhatsky 2009-12-01 08:08:18 PST
Created attachment 44080 [details]
patch addressing comments that I'm going to land
Comment 7 Yury Semikhatsky 2009-12-01 08:08:48 PST
(In reply to comment #5)
> (From update of attachment 44076 [details])
> Maybe we should call this mainWorldScriptState to be explicit?
Done.
Comment 8 Yury Semikhatsky 2009-12-01 08:24:02 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/bindings/v8/ScriptController.cpp
	M	WebCore/bindings/v8/ScriptController.h
	M	WebCore/bindings/v8/ScriptState.cpp
Committed r51538