Bug 32004 - Reloading WebInspector from context menu is closing it instead of reloading.
Summary: Reloading WebInspector from context menu is closing it instead of reloading.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-30 19:17 PST by Yael
Modified: 2009-12-01 09:24 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.36 KB, patch)
2009-12-01 06:41 PST, Yael
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2009-11-30 19:17:26 PST
Opening WebInspector and reloading it from the context menu is closing it, but not reopening it.
The reason is that the m_page of the InspectorController is being cleared but a new one is not being created.
A patch will be coming soon.
Comment 1 Yael 2009-12-01 06:41:30 PST
Created attachment 44071 [details]
Patch

Do not delete the page associated with the WebInspector during a reload.
Comment 2 Yael 2009-12-01 06:44:30 PST
This patch does not fix the problem for Qt port, only for Mac port.
Comment 3 WebKit Review Bot 2009-12-01 06:45:18 PST
style-queue ran check-webkit-style on attachment 44071 [details] without any errors.
Comment 4 Eric Seidel (no email) 2009-12-01 07:17:08 PST
Comment on attachment 44071 [details]
Patch

Seems we should have a manual test for this.  Or some sort of test.
Comment 5 WebKit Commit Bot 2009-12-01 09:24:18 PST
Comment on attachment 44071 [details]
Patch

Clearing flags on attachment: 44071

Committed r51544: <http://trac.webkit.org/changeset/51544>
Comment 6 WebKit Commit Bot 2009-12-01 09:24:22 PST
All reviewed patches have been landed.  Closing bug.