Bug 31993 – http://webkit.org/coding/coding-style.html should mention check-webkit-style

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Website

[Eric Seidel (no email)]

http://webkit.org/coding/coding-style.html should mention check-webkit-style

We now have this nice tool for checking some of the rules of WebKit style.  Our style page should mention the tool and explain its use.

[ezisfake]

Created attachment 218051 [details]
Patch

[ezisfake]

ping

[László Langó]

(In reply to comment #1)
> Created an attachment (id=218051) [details]
> Patch

I think we need a more detailed description of it's usage.

[Darin Adler]

Comment on attachment 218051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218051&action=review

> Websites/webkit.org/coding/contributing.html:94
> +<p>Your patch will be automatically checked for style compliance before uploading if you use webkit-patch upload.

This mention of webkit-patch upload here is not formatted the way the other mentions in this document are.

> Websites/webkit.org/coding/contributing.html:95
> +You can do it manually with the check-webkit-style script and will be checked always after uploading by <a href="http://trac.webkit.org/wiki/EWS">EWS</a>.

Grammar mistake here. It says:

    You can do it and will be checked

I would write something more like this:

    You can check style manually by running the Tools/Scripts/check-webkit-style script. Style will also be checked on each patch after it is uploaded by the <a href="http://trac.webkit.org/wiki/EWS">WebKit Early Warning System</a>.

It’s a little strange to have a link to the wiki from this page. Normally we don’t do that.

[László Langó]

Created attachment 237220 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 237220 [details]
Patch for landing

Clearing flags on attachment: 237220

Committed r173003: <http://trac.webkit.org/changeset/173003>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.