Bug 31980 - REGRESSION (r49757): masking-mask-01-b.svg rendered incorrectly
Summary: REGRESSION (r49757): masking-mask-01-b.svg rendered incorrectly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-30 03:12 PST by Yuta Kitamura
Modified: 2009-11-30 18:03 PST (History)
3 users (show)

See Also:

Attachments
Expected and current rendering (32.17 KB, image/png)
2009-11-30 03:12 PST, Yuta Kitamura 		no flags Details
Test case for SVG mask (1.27 KB, image/svg+xml)
2009-11-30 05:07 PST, Dirk Schulze 		no flags Details
fix of SVG Mask (23.18 KB, patch)
2009-11-30 08:49 PST, Dirk Schulze 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2009-11-30 03:12:35 PST 
Created attachment 44014 [details]
Expected and current rendering

LayoutTests/svg/W3C-SVG-1.1/masking-mask-01-b.svg

This test has been failing since r49757. SVG masks are not working correctly.
Comment 1 Yuta Kitamura 2009-11-30 03:14:13 PST 
Dirk, do you have any idea on this?
Comment 2 Dirk Schulze 2009-11-30 03:33:44 PST 
I can reproduce this in trunk. I'm currently building r49757. If this comes with this commit, we still have a bug in the calculation of  the mask region. I'll take a look at it.
Comment 3 Dirk Schulze 2009-11-30 05:07:34 PST 
Created attachment 44016 [details]
Test case for SVG mask

It looks like the combination of maskUnits="userSpaceOnUse" with maskContentUnits="userSpaceOnUse" on a mask element doesn't work atm.
Comment 4 Dirk Schulze 2009-11-30 08:49:19 PST 
Created attachment 44022 [details]
fix of SVG Mask

This should fix SVG Mask for sure this time (hopefully ;-)). I added a more complex test of all combinations of maskUnits and maskContentUnits. LayoutTests/svg/W3C-SVG-1.1/masking-mask-01-b.svg works again now.
Comment 5 Nikolas Zimmermann 2009-11-30 09:16:10 PST 
Comment on attachment 44022 [details]
fix of SVG Mask

LGTM. r=me.
Comment 6 WebKit Commit Bot 2009-11-30 09:25:07 PST 
Comment on attachment 44022 [details]
fix of SVG Mask

Clearing flags on attachment: 44022

Committed r51496: <http://trac.webkit.org/changeset/51496>
Comment 7 WebKit Commit Bot 2009-11-30 09:25:12 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Yuta Kitamura 2009-11-30 18:03:12 PST 
Confirmed. Thanks!