Bug 31978 - Chrome::contentsSizeChanged() is called when the content size has not changed
Summary: Chrome::contentsSizeChanged() is called when the content size has not changed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-11-30 01:38 PST by Benjamin Poulain
Modified: 2009-11-30 08:56 PST (History)
2 users (show)

See Also:


Attachments
Add a condition to skip the update (1.08 KB, patch)
2009-11-30 01:41 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2009-11-30 01:38:36 PST
Chrome::contentsSizeChanged() is called systematically when FrameView::setContentsSize() is called. This means this functions is also called when the size has not changed.

The view itself ignores the change since ScrollView::setContentsSize() check if the size if different:
    if (contentsSize() == newSize)
        return;
    [...]

FrameView::setContentsSize() does not do such check and Chrome::contentsSizeChanged() is always called.
Comment 1 Benjamin Poulain 2009-11-30 01:41:13 PST
Created attachment 44012 [details]
Add a condition to skip the update
Comment 2 WebKit Commit Bot 2009-11-30 08:56:37 PST
Comment on attachment 44012 [details]
Add a condition to skip the update

Clearing flags on attachment: 44012

Committed r51492: <http://trac.webkit.org/changeset/51492>
Comment 3 WebKit Commit Bot 2009-11-30 08:56:48 PST
All reviewed patches have been landed.  Closing bug.