Bug 31976 - Update pywebsocket to 0.4.2.1
Summary: Update pywebsocket to 0.4.2.1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-29 21:54 PST by Yuzo Fujishima
Modified: 2009-11-30 16:40 PST (History)
3 users (show)

See Also:


Attachments
Update pywebsocket to 0.4.2.1 (2.06 KB, patch)
2009-11-29 21:57 PST, Yuzo Fujishima
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuzo Fujishima 2009-11-29 21:54:18 PST
Update pywebsocket (http://code.google.com/p/pywebsocket/) to 0.4.2.1.

0.4.2 has a bug that some errors are logged to stderr even when log file is specified.
For 0.4.2.1 the bug has been fixed.
Comment 1 Yuzo Fujishima 2009-11-29 21:57:13 PST
Created attachment 44007 [details]
Update pywebsocket to 0.4.2.1
Comment 2 Adam Barth 2009-11-30 12:49:37 PST
style-queue ran check-webkit-style on attachment 44007 [details] without any errors.
Comment 3 Alexey Proskuryakov 2009-11-30 16:31:04 PST
Comment on attachment 44007 [details]
Update pywebsocket to 0.4.2.1

> +        Update pywebsocket to 0.4.2.1.

Do we really need 4-digit version numbers for pywebsocket? I'm not sure if any version numbers are needed at this point.

> +        logging.error(
> +            ('Exception in processing request from: %r' % (client_address,)) +
> +            '\n' + util.get_stack_trace())

We don't usually wrap such short lines.

> +        # Note: client_address is a tuple. To match it against %r, we need the
> +        # trailing comma.

Ditto.

r=me
Comment 4 WebKit Commit Bot 2009-11-30 16:40:11 PST
Comment on attachment 44007 [details]
Update pywebsocket to 0.4.2.1

Clearing flags on attachment: 44007

Committed r51521: <http://trac.webkit.org/changeset/51521>
Comment 5 WebKit Commit Bot 2009-11-30 16:40:16 PST
All reviewed patches have been landed.  Closing bug.