validate-committer-lists fails when run from an SVN checkout We should at least display a nice warning if we require Git. Only one of the checks (checking against historical committers) requires a git checkout. It's possible we could even do the check using a remote git repository. fatal: Not a git repository (or any of the parent directories): .git Traceback (most recent call last): File "./validate-committer-lists", line 252, in <module> main() File "./validate-committer-lists", line 248, in main svn_committer_list.print_possibly_expired_committers(committer_list) File "./validate-committer-lists", line 211, in print_possibly_expired_committers authors_and_last_commits = self._last_commit_by_author().items() File "./validate-committer-lists", line 203, in _last_commit_by_author del self._last_commit_time_by_author_cache['(no author)'] # The initial svn import isn't very useful. KeyError: '(no author)'
Created attachment 45400 [details] Patch
style-queue ran check-webkit-style on attachment 45400 [details] without any errors.
Evan, it's not possible to point git log at a remote repository is it? The only command we need git for is: git log --reverse --pretty="format:%ae %at" Trying to do that with SVN would take at least 3 eons. It's already slow enough w/ git.
Comment on attachment 45400 [details] Patch Clearing flags on attachment: 45400 Committed r52501: <http://trac.webkit.org/changeset/52501>
All reviewed patches have been landed. Closing bug.
(In reply to comment #3) > Evan, it's not possible to point git log at a remote repository is it? > > The only command we need git for is: > git log --reverse --pretty="format:%ae %at" > > Trying to do that with SVN would take at least 3 eons. It's already slow > enough w/ git. Unfortunately, it's not possible.