Bug 31974 - validate-committer-lists fails when run from an SVN checkout
Summary: validate-committer-lists fails when run from an SVN checkout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-29 19:57 PST by Eric Seidel (no email)
Modified: 2009-12-23 04:18 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.84 KB, patch)
2009-12-22 13:56 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-11-29 19:57:06 PST
validate-committer-lists fails when run from an SVN checkout

We should at least display a nice warning if we require Git.  Only one of the checks (checking against historical committers) requires a git checkout.  It's possible we could even do the check using a remote git repository.

fatal: Not a git repository (or any of the parent directories): .git
Traceback (most recent call last):
  File "./validate-committer-lists", line 252, in <module>
    main()
  File "./validate-committer-lists", line 248, in main
    svn_committer_list.print_possibly_expired_committers(committer_list)
  File "./validate-committer-lists", line 211, in print_possibly_expired_committers
    authors_and_last_commits = self._last_commit_by_author().items()
  File "./validate-committer-lists", line 203, in _last_commit_by_author
    del self._last_commit_time_by_author_cache['(no author)'] # The initial svn import isn't very useful.
KeyError: '(no author)'
Comment 1 Eric Seidel (no email) 2009-12-22 13:56:07 PST
Created attachment 45400 [details]
Patch
Comment 2 WebKit Review Bot 2009-12-22 13:57:09 PST
style-queue ran check-webkit-style on attachment 45400 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-22 14:06:05 PST
Evan, it's not possible to point git log at a remote repository is it?

The only command we need git for is:
git log --reverse --pretty="format:%ae %at"

Trying to do that with SVN would take at least 3 eons.  It's already slow enough w/ git.
Comment 4 WebKit Commit Bot 2009-12-22 14:18:50 PST
Comment on attachment 45400 [details]
Patch

Clearing flags on attachment: 45400

Committed r52501: <http://trac.webkit.org/changeset/52501>
Comment 5 WebKit Commit Bot 2009-12-22 14:18:55 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Evan Martin 2009-12-23 04:18:23 PST
(In reply to comment #3)
> Evan, it's not possible to point git log at a remote repository is it?
> 
> The only command we need git for is:
> git log --reverse --pretty="format:%ae %at"
> 
> Trying to do that with SVN would take at least 3 eons.  It's already slow
> enough w/ git.

Unfortunately, it's not possible.