Bug 31969 – Cleanup: Remove unnecessary #includes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Daniel Bates]

We can remove the following #includes, because they are unnecessary (either they aren't used or are indirectly included by other #includes):

css/CSSComputedStyleDeclaration.cpp: CachedImage.h, and Pair.h
css/CSSCursorImageValue.cpp: RenderStyle.h
css/CSSFontFaceSrcValue.cpp: Node.h
css/CSSFontSelector.cpp: NodeList.h
css/CSSGradientValue.cpp: GraphicsContext.h, ImageBuffer.h
css/CSSImageValue.cpp: RenderStyle.h
css/CSSMutableStyleDeclaration.cpp: CSSProperty.h
css/CSSRule.cpp: CSSStyleSheet.h
css/CSSStyleSelector.cpp: CSSFontFace.h, CSSFontFaceSource.h, and CSSProperty.h
page/EventSource.h: EventListener.h

[Daniel Bates]

Created attachment 44001 [details]
Patch

No functionality was changed. So, no new tests.

[Daniel Bates]

Created attachment 44003 [details]
Patch

Found another one:

css/CSSImportRule.cpp: MediaList.h

[Eric Seidel (no email)]

Comment on attachment 44003 [details]
Patch

OK.  I assume you used the script?

[Daniel Bates]

No. I did this by hand. What script are you talking about? And if we have a script, why don't we use it?

(In reply to comment #3)
> (From update of attachment 44003 [details])
> OK.  I assume you used the script?

[Daniel Bates]

Committed r51473: <http://trac.webkit.org/changeset/51473>

[Laszlo Gombos]

This change seems to break the QtWebkit build. Here is the build error:

WebCore/css/CSSFontFaceSrcValue.cpp: In member function 'virtual void WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs(WTF::ListHashSet<WebCore::KURL, WebCore::KURLHash>&, const WebCore::CSSStyleSheet*)':

WebCore/css/CSSFontFaceSrcValue.cpp:74: error: 'addSubresourceURL' was not declared in this scope
make[1]: *** [obj/release/CSSFontFaceSrcValue.o] Error 1

Daniel, can you check this ?

[Laszlo Gombos]

This is now fixed by the following change:

http://trac.webkit.org/changeset/51520