Bug 31967 - update-webkit --chromium forces gclient sync
Summary: update-webkit --chromium forces gclient sync
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-29 17:15 PST by Yaar Schnitman
Modified: 2009-11-30 09:10 PST (History)
2 users (show)

See Also:


Attachments
update-webkit --chromium forces gclient sync (956 bytes, patch)
2009-11-29 17:17 PST, Yaar Schnitman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yaar Schnitman 2009-11-29 17:15:14 PST
gclient sync should be invoked with --force flag.
Comment 1 Yaar Schnitman 2009-11-29 17:17:37 PST
Created attachment 43998 [details]
update-webkit --chromium forces gclient sync
Comment 2 Darin Fisher (:fishd, Google) 2009-11-29 19:23:04 PST
Why is this necessary?  Isn't it a bit unfriendly to developers that want to run update-webkit manually?  Is this a mode that you want for the buildbots?  If so is there an environment variable we can use to toggle this mode?
Comment 3 Yaar Schnitman 2009-11-30 08:59:15 PST
(In reply to comment #2)
> Why is this necessary?  Isn't it a bit unfriendly to developers that want to
> run update-webkit manually?  Is this a mode that you want for the buildbots? 
> If so is there an environment variable we can use to toggle this mode?

Yes, this is unfriendly, but necessary for the bots. I will fix the unpleasantness in a subsequent patch.
Comment 4 Dimitri Glazkov (Google) 2009-11-30 09:02:41 PST
Comment on attachment 43998 [details]
update-webkit --chromium forces gclient sync

ok. Don't forget to file a follow-up bug to fix this.
Comment 5 WebKit Commit Bot 2009-11-30 09:10:44 PST
Comment on attachment 43998 [details]
update-webkit --chromium forces gclient sync

Clearing flags on attachment: 43998

Committed r51494: <http://trac.webkit.org/changeset/51494>
Comment 6 WebKit Commit Bot 2009-11-30 09:10:49 PST
All reviewed patches have been landed.  Closing bug.