KDE is now using the "vanilla" QtWebKit - there is no KDE specific code remained in WebKit. As far as I can this is the case after r18098.
Created attachment 43989 [details] proposed change
OK, I believe you. CC'd a few folks who I believe still work on KDE.
Thanks Eric for the review. I will wait about a week to see if anyone would object to this and will commit it.
Nice cleanup! I believe that's the correct change. KDE has now a layer on top of QtWebKit, it does not require a special build/set of #ifdefs.
Comment on attachment 43989 [details] proposed change Rejecting patch 43989 from commit-queue. Failed to run "['WebKitTools/Scripts/build-webkit']" exit_code: 1 Last 500 characters of output: Script-14D857B50A469C100032146C.sh === BUILDING AGGREGATE TARGET All OF PROJECT JavaScriptCore WITH CONFIGURATION Release === Checking Dependencies... ** BUILD FAILED ** The following build commands failed: JavaScriptCore: Distributed-CompileC /Users/eseidel/Projects/CommitQueue/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal/i386/Lexer.o /Users/eseidel/Projects/CommitQueue/JavaScriptCore/parser/Lexer.cpp normal i386 c++ com.apple.compilers.gcc.4_2 (1 failure)
The commit queue got stuck on this patch for hours before I restarted it. I think it was a python compilation problem in the end since it went away after restart. bug 31983. It failed very quickly after restart, I've not tried applying it manually, but I believe this is a real compile failure.
Comment on attachment 43989 [details] proposed change Clearing review flag as I think the build bot is right this time. Will fix the patch and resubmit for review.
Created attachment 44033 [details] Put back Grammar.h to Lexer.cpp is it is guarded with if_n_def KDE_USE_FINAL
Comment on attachment 44033 [details] Put back Grammar.h to Lexer.cpp is it is guarded with if_n_def KDE_USE_FINAL Clearing flags on attachment: 44033 Committed r51505: <http://trac.webkit.org/changeset/51505>
All reviewed patches have been landed. Closing bug.