Bug 31958 - [Qt] Remove obsolete PLATFORM(KDE) code
Summary: [Qt] Remove obsolete PLATFORM(KDE) code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-11-28 22:11 PST by Laszlo Gombos
Modified: 2009-11-30 12:42 PST (History)
7 users (show)

See Also:


Attachments
proposed change (2.03 KB, patch)
2009-11-28 22:16 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff
Put back Grammar.h to Lexer.cpp is it is guarded with if_n_def KDE_USE_FINAL (2.06 KB, patch)
2009-11-30 11:56 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-11-28 22:11:25 PST
KDE is now using the "vanilla" QtWebKit - there is no KDE specific code remained in WebKit. As far as I can this is the case after r18098.
Comment 1 Laszlo Gombos 2009-11-28 22:16:52 PST
Created attachment 43989 [details]
proposed change
Comment 2 Eric Seidel (no email) 2009-11-29 07:14:31 PST
OK, I believe you.  CC'd a few folks who I believe still work on KDE.
Comment 3 Laszlo Gombos 2009-11-29 14:45:41 PST
Thanks Eric for the review. 

I will wait about a week to see if anyone would object to this and will commit it.
Comment 4 Simon Hausmann 2009-11-29 15:43:45 PST
Nice cleanup! I believe that's the correct change.

KDE has now a layer on top of QtWebKit, it does not require a special build/set of #ifdefs.
Comment 5 WebKit Commit Bot 2009-11-30 08:24:06 PST
Comment on attachment 43989 [details]
proposed change

Rejecting patch 43989 from commit-queue.

Failed to run "['WebKitTools/Scripts/build-webkit']" exit_code: 1
Last 500 characters of output:
Script-14D857B50A469C100032146C.sh


=== BUILDING AGGREGATE TARGET All OF PROJECT JavaScriptCore WITH CONFIGURATION Release ===

Checking Dependencies...
** BUILD FAILED **

The following build commands failed:
JavaScriptCore:
	Distributed-CompileC /Users/eseidel/Projects/CommitQueue/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal/i386/Lexer.o /Users/eseidel/Projects/CommitQueue/JavaScriptCore/parser/Lexer.cpp normal i386 c++ com.apple.compilers.gcc.4_2
(1 failure)
Comment 6 Eric Seidel (no email) 2009-11-30 08:29:38 PST
The commit queue got stuck on this patch for hours before I restarted it.  I think it was a python compilation problem in the end since it went away after restart.  bug 31983.  It failed very quickly after restart, I've not tried applying it manually, but I believe this is a real compile failure.
Comment 7 Laszlo Gombos 2009-11-30 11:08:15 PST
Comment on attachment 43989 [details]
proposed change

Clearing review flag as I think the build bot is right this time. Will fix the patch and resubmit for review.
Comment 8 Laszlo Gombos 2009-11-30 11:56:51 PST
Created attachment 44033 [details]
Put back Grammar.h to Lexer.cpp is it is guarded with if_n_def KDE_USE_FINAL
Comment 9 WebKit Commit Bot 2009-11-30 12:42:26 PST
Comment on attachment 44033 [details]
Put back Grammar.h to Lexer.cpp is it is guarded with if_n_def KDE_USE_FINAL

Clearing flags on attachment: 44033

Committed r51505: <http://trac.webkit.org/changeset/51505>
Comment 10 WebKit Commit Bot 2009-11-30 12:42:33 PST
All reviewed patches have been landed.  Closing bug.