Bug 31955 - postMessage should serialize File objects
Summary: postMessage should serialize File objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-28 15:48 PST by Oliver Hunt
Modified: 2009-11-29 20:23 PST (History)
0 users

See Also:


Attachments
Patch (7.25 KB, patch)
2009-11-28 17:00 PST, Oliver Hunt
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2009-11-28 15:48:41 PST
the internal structured cloning algorithm indicates that we should clone File objects
Comment 1 Oliver Hunt 2009-11-28 17:00:27 PST
Created attachment 43986 [details]
Patch
Comment 2 Sam Weinig 2009-11-28 19:03:25 PST
Comment on attachment 43986 [details]
Patch

>          SerializedType type() const { return m_type; }
> @@ -77,6 +79,8 @@ namespace WebCore {
>              , m_string(string.crossThreadString()) // FIXME: Should be able to just share the Rep
>          {
>          }
> +        
> +        explicit SerializedScriptValueData(const File* file);

The parameter name is not necessary here.

r=me
Comment 3 Oliver Hunt 2009-11-29 20:23:25 PST
Committed r51480