RESOLVED FIXED Bug 31944
[bzt] style-queue shouldn't reject patches from the commit-queue 
https://bugs.webkit.org/show_bug.cgi?id=31944
Summary [bzt] style-queue shouldn't reject patches from the commit-queue
Adam Barth
Reported 2009-11-27 16:31:53 PST
Currently the style-queue subprocess gets confused and thinks its the commit-queue. If the patch has an error, it rejects it from the commit-queue. Instead, we should have style-queue specific logic. This patch doesn't add that logic, but it gives us a callback we can use to add that logic.
Attachments
Patch (6.95 KB, patch)
2009-11-27 16:32 PST, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-11-27 16:32:55 PST
Created attachment 43975 [details] Patch
Eric Seidel (no email)
Comment 2 2009-11-27 18:06:28 PST
I don't understand this patch or why it needs a command-line arg. I think the command-line arg is the part that really confuses me (it's kinda ugly).
Adam Barth
Comment 3 2009-11-27 18:11:29 PST
The child process needs to know what to do with errors. The command line argument tells the child what command understands the errors and therefore who should process them.
Eric Seidel (no email)
Comment 4 2009-11-28 09:50:41 PST
Comment on attachment 43975 [details] Patch Seems OK. --parent-command would be better as per our discussion.
Adam Barth
Comment 5 2009-11-28 10:27:42 PST
Committed r51460: <http://trac.webkit.org/changeset/51460>
Adam Barth
Comment 6 2009-11-28 10:28:28 PST
Patch landed.
Note You need to log in before you can comment on or make changes to this bug.