Bug 31940 - [XSSAuditor] Make the error messages more descriptive for refused objects and base URL
Summary: [XSSAuditor] Make the error messages more descriptive for refused objects and...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: XSSAuditor
Depends on:
Blocks:
 
Reported: 2009-11-27 13:32 PST by Daniel Bates
Modified: 2009-11-27 15:05 PST (History)
2 users (show)

See Also:

Attachments
Patch with rebased tests (12.33 KB, patch)
2009-11-27 13:35 PST, Daniel Bates 		abarth: review-
Details | Formatted Diff | Diff
Patch with rebased tests (12.28 KB, patch)
2009-11-27 14:29 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2009-11-27 13:32:23 PST 
We should make the error messages more descriptive when we refuse to load an object or refuse to load from the document base URL.
Comment 1 Daniel Bates 2009-11-27 13:35:00 PST 
Created attachment 43969 [details]
Patch with rebased tests

Rebased some tests because of the changed console messages.
Comment 2 Adam Barth 2009-11-27 14:09:34 PST 
Comment on attachment 43969 [details]
Patch with rebased tests

This is a great idea, but we like to use String::format instead of + to create these kinds of messages.  You can see examples in some of the other console messages.
Comment 3 Daniel Bates 2009-11-27 14:29:15 PST 
Created attachment 43970 [details]
Patch with rebased tests

Changed to use String::format. Other examples did not use a static format message, so neither did I.
Comment 4 Adam Barth 2009-11-27 14:37:37 PST 
Comment on attachment 43970 [details]
Patch with rebased tests

thanks!
Comment 5 Daniel Bates 2009-11-27 15:05:16 PST 
Comment on attachment 43970 [details]
Patch with rebased tests

Clearing flags on attachment: 43970

Committed r51445: <http://trac.webkit.org/changeset/51445>
Comment 6 Daniel Bates 2009-11-27 15:05:22 PST 
All reviewed patches have been landed.  Closing bug.