RESOLVED FIXED 31940
[XSSAuditor] Make the error messages more descriptive for refused objects and base URL 
https://bugs.webkit.org/show_bug.cgi?id=31940
Summary [XSSAuditor] Make the error messages more descriptive for refused objects and...
Daniel Bates
Reported 2009-11-27 13:32:23 PST
We should make the error messages more descriptive when we refuse to load an object or refuse to load from the document base URL.
Attachments
Patch with rebased tests (12.33 KB, patch)
2009-11-27 13:35 PST, Daniel Bates 		abarth: review-
DetailsFormatted DiffDiff
Patch with rebased tests (12.28 KB, patch)
2009-11-27 14:29 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2009-11-27 13:35:00 PST
Created attachment 43969 [details] Patch with rebased tests Rebased some tests because of the changed console messages.
Adam Barth
Comment 2 2009-11-27 14:09:34 PST
Comment on attachment 43969 [details] Patch with rebased tests This is a great idea, but we like to use String::format instead of + to create these kinds of messages. You can see examples in some of the other console messages.
Daniel Bates
Comment 3 2009-11-27 14:29:15 PST
Created attachment 43970 [details] Patch with rebased tests Changed to use String::format. Other examples did not use a static format message, so neither did I.
Adam Barth
Comment 4 2009-11-27 14:37:37 PST
Comment on attachment 43970 [details] Patch with rebased tests thanks!
Daniel Bates
Comment 5 2009-11-27 15:05:16 PST
Comment on attachment 43970 [details] Patch with rebased tests Clearing flags on attachment: 43970 Committed r51445: <http://trac.webkit.org/changeset/51445>
Daniel Bates
Comment 6 2009-11-27 15:05:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.