RESOLVED INVALID 31937
WebKit build breakage on Chromium 
https://bugs.webkit.org/show_bug.cgi?id=31937
Summary WebKit build breakage on Chromium
Jonathan Dixon
Reported 2009-11-27 10:47:57 PST
Build is broken with errors in WebCore/rendering/RenderThemeChromiumSkia.cpp (missing { before ;) JavaScriptCore/wtf/gtk/GOwnPtr.cpp (spurious file including glib.h)
Attachments
One line changes to fix chromium build (2.33 KB, patch)
2009-11-27 10:48 PST, Jonathan Dixon 		eric: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Dixon
Comment 1 2009-11-27 10:48:55 PST
Created attachment 43961 [details] One line changes to fix chromium build
Eric Seidel (no email)
Comment 2 2009-11-28 09:44:56 PST
Comment on attachment 43961 [details] One line changes to fix chromium build LGTM.
WebKit Commit Bot
Comment 3 2009-11-28 09:49:56 PST
Comment on attachment 43961 [details] One line changes to fix chromium build Rejecting patch 43961 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1 Last 500 characters of output: iptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp Hunk #1 FAILED at 115. 1 out of 1 hunk FAILED -- saving rejects to file JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp.rej patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/rendering/RenderThemeChromiumSkia.cpp Hunk #1 FAILED at 348. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/rendering/RenderThemeChromiumSkia.cpp.rej
Eric Seidel (no email)
Comment 4 2009-11-28 10:00:17 PST
Looks like the patch rotted (or was already landed).
Jonathan Dixon
Comment 5 2009-12-01 08:42:41 PST
Already fixed in changes: http://trac.webkit.org/changeset/51455 http://trac.webkit.org/changeset/51452
Note You need to log in before you can comment on or make changes to this bug.