Bug 31921 – Use ProgressTracker from the inspected page to generate ids for cached resources

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

Instead of generating negative identifiers for cached resources in InspectorController and extending identifier type from 'unsigned long' to 'long long' it would be better to reuse progress tracker for the inspected page to generate those identifiers. It would guarantee that InspectorResources' ids are unique.

[Yury Semikhatsky]

Created attachment 43932 [details]
patch

[Yury Semikhatsky]

Created attachment 43937 [details]
patch

[Pavel Feldman]

Comment on attachment 43937 [details]
patch

I don't think we need to add methods for setting various integers - we don't even use existing ones. Can we optimize it in a way that there are only methods for signed, unsigned and floating point? That API would be easier to maintain and there will not be that much copy-paste in the code.

[Yury Semikhatsky]

(In reply to comment #3)
> (From update of attachment 43937 [details])
> I don't think we need to add methods for setting various integers - we don't
> even use existing ones. Can we optimize it in a way that there are only methods
> for signed, unsigned and floating point? That API would be easier to maintain
> and there will not be that much copy-paste in the code.

We cannot reduce the number of overloaded methods without introducing lots of static_casts because if we had just double and bool there would be ambiguity for ints if we had double, bool and int there is ambiguity for long and so on.

[Yury Semikhatsky]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/ScriptFunctionCall.cpp
	M	WebCore/bindings/js/ScriptFunctionCall.h
	M	WebCore/bindings/js/ScriptObject.cpp
	M	WebCore/bindings/js/ScriptObject.h
	M	WebCore/bindings/v8/ScriptFunctionCall.cpp
	M	WebCore/bindings/v8/ScriptFunctionCall.h
	M	WebCore/bindings/v8/ScriptObject.cpp
	M	WebCore/bindings/v8/ScriptObject.h
	M	WebCore/inspector/InspectorBackend.cpp
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorController.h
	M	WebCore/inspector/InspectorDOMAgent.cpp
	M	WebCore/inspector/InspectorFrontend.cpp
	M	WebCore/inspector/InspectorFrontend.h
	M	WebCore/inspector/InspectorResource.cpp
	M	WebCore/inspector/InspectorResource.h
	M	WebCore/inspector/TimelineRecordFactory.cpp
Committed r51439