RESOLVED FIXED 31907
Modify linux commands in SCM unittests to pass tests 
https://bugs.webkit.org/show_bug.cgi?id=31907
Summary Modify linux commands in SCM unittests to pass tests
Zoltan Horvath
Reported 2009-11-26 03:06:26 PST
Created attachment 43912 [details] Patch Reviewed by NOBODY (OOPS!). Remove directory prefixes from linux commands SCM unittests can cause errors on some systems if we use absolute reference to the commands, so directory prefixes have been removed. * Scripts/modules/scm_unittest.py:
Attachments
Patch (2.69 KB, patch)
2009-11-26 03:06 PST, Zoltan Horvath 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-11-26 07:46:55 PST
Comment on attachment 43912 [details] Patch LGTM.
Zoltan Horvath
Comment 2 2009-11-26 08:54:38 PST
Committed r51417: <http://trac.webkit.org/changeset/51417>
Eric Seidel (no email)
Comment 3 2009-11-26 10:53:41 PST
Comment on attachment 43912 [details] Patch I'm surprised this works on all systems, but OK. I though that our use of POpen has shell=False, but maybe not.
Note You need to log in before you can comment on or make changes to this bug.