Bug 31905 - SVG feImage support
Summary: SVG feImage support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 525.x (Safari 3.1)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 68469 12027 26389
  Show dependency tree / graph
 
Reported: 2009-11-26 01:21 PST by Dirk Schulze
Modified: 2014-05-12 05:54 PDT (History)
4 users (show)

See Also:

Attachments
SVG feImage support (25.42 KB, patch)
2009-11-26 06:50 PST, Dirk Schulze 		no flags Details | Formatted Diff | Diff
SVG feImage support (25.56 KB, patch)
2009-12-01 15:02 PST, Dirk Schulze 		no flags Details | Formatted Diff | Diff
SVG feImage support (365.44 KB, patch)
2010-01-06 09:10 PST, Dirk Schulze 		zimmermann: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2009-11-26 01:21:46 PST 
We need basic support for filter effect feImage.
Comment 1 Dirk Schulze 2009-11-26 06:50:05 PST 
Created attachment 43919 [details]
SVG feImage support

This is the implementation if feImage. It still lacks RenderObject* support, to draw parts of the SVG as image. See bug 12027.
Comment 2 Adam Barth 2009-11-30 12:44:04 PST 
Attachment 43919 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/svg/SVGImageLoader.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Done processing WebCore/svg/SVGImageLoader.cpp
Done processing WebCore/rendering/RenderSVGImage.cpp
Done processing WebCore/svg/SVGFEImageElement.h
Done processing WebCore/svg/SVGPreserveAspectRatio.h
WebCore/svg/SVGPreserveAspectRatio.cpp:176:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/svg/SVGPreserveAspectRatio.cpp:191:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/svg/SVGPreserveAspectRatio.cpp:210:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/svg/SVGPreserveAspectRatio.cpp:227:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Done processing WebCore/svg/SVGPreserveAspectRatio.cpp
Done processing WebCore/svg/SVGFEImageElement.cpp
Done processing WebCore/svg/graphics/filters/SVGFEImage.h
Done processing WebCore/rendering/RenderSVGImage.h
WebCore/svg/SVGImageLoader.h:30:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Done processing WebCore/svg/SVGImageLoader.h
Done processing WebCore/svg/graphics/filters/SVGFEImage.cpp
Total errors found: 6
Comment 3 Dirk Schulze 2009-12-01 15:02:35 PST 
Created attachment 44105 [details]
SVG feImage support

fixed style issues.
Comment 4 WebKit Review Bot 2009-12-01 15:06:52 PST 
style-queue ran check-webkit-style on attachment 44105 [details] without any errors.
Comment 5 Dirk Schulze 2009-12-04 13:26:02 PST 
Comment on attachment 44105 [details]
SVG feImage support

The current patch does not account notifyFinished. I'll upload a new patch.
Comment 6 Dirk Schulze 2010-01-06 09:10:02 PST 
Created attachment 45964 [details]
SVG feImage support

SVG feImage support.
Comment 7 WebKit Review Bot 2010-01-06 09:16:00 PST 
Attachment 45964 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Traceback (most recent call last):
  File "WebKitTools/Scripts/check-webkit-style", line 98, in <module>
    main()
  File "WebKitTools/Scripts/check-webkit-style", line 62, in main
    defaults = style.ArgumentDefaults(style.DEFAULT_OUTPUT_FORMAT,
AttributeError: 'module' object has no attribute 'ArgumentDefaults'
Comment 8 Nikolas Zimmermann 2010-01-06 11:58:41 PST 
Comment on attachment 45964 [details]
SVG feImage support

Can't remember how many times we reiterated this patch.... it's soo perfect this time :-) Enthusiastically r+ed!
Comment 9 Dirk Schulze 2010-01-06 14:10:50 PST 
landed in r52865. closing the bug now.