RESOLVED FIXED 31903
[bzt] Unit test upload commands 
https://bugs.webkit.org/show_bug.cgi?id=31903
Summary [bzt] Unit test upload commands
Adam Barth
Reported 2009-11-25 23:31:53 PST
My quest to unit test every command begins. Let's start with the upload commands.
Attachments
upload unittests (16.82 KB, patch)
2009-11-25 23:34 PST, Adam Barth 		eric: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-11-25 23:34:30 PST
Created attachment 43899 [details] upload unittests
Eric Seidel (no email)
Comment 2 2009-11-26 10:56:57 PST
Comment on attachment 43899 [details] upload unittests The fixme is "wrong". See the commends in BugzillaTool as to why .scm() is a function. Otherwise looks OK.
Adam Barth
Comment 3 2009-11-26 11:19:46 PST
Comment on attachment 43899 [details] upload unittests I understand the problem you're solving by making scm a function. We should either make everything a function or find another way to solve that problem. In any case, a very low priority issue.
WebKit Commit Bot
Comment 4 2009-11-26 11:25:40 PST
Comment on attachment 43899 [details] upload unittests Rejecting patch 43899 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11667 test cases. fast/canvas/webgl/gl-object-get-calls.html -> failed Exiting early after 1 failures. 4970 tests run. 89.29s total testing time 4969 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output
Eric Seidel (no email)
Comment 5 2009-11-26 11:46:52 PST
Failure caused by bug 31919. This should be landed manually w/ adjusted fixme anyway, no? ;)
Adam Barth
Comment 6 2009-11-27 00:02:14 PST
Committed r51436: <http://trac.webkit.org/changeset/51436>
Note You need to log in before you can comment on or make changes to this bug.