Bug 31891 - Off-by-one error in index validation for drawElements and drawArrays
Summary: Off-by-one error in index validation for drawElements and drawArrays
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Major
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-25 16:11 PST by Kenneth Russell
Modified: 2009-12-15 14:57 PST (History)
6 users (show)

See Also:

Attachments
Patch (6.43 KB, patch)
2009-11-25 16:15 PST, Kenneth Russell 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2009-11-25 16:11:24 PST 
There is an off-by-one error in the index validation introduced in https://bugs.webkit.org/show_bug.cgi?id=31239 which is one of the reasons some demos no longer work. The computation of the available elements in the bound array buffers does not take into account the fact that for the last element, the number of bytes touched is only that of the data itself, not including the stride.
Comment 1 Kenneth Russell 2009-11-25 16:15:46 PST 
Created attachment 43875 [details]
Patch
Comment 2 Oliver Hunt 2009-11-25 16:25:51 PST 
Comment on attachment 43875 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2009-11-25 16:44:49 PST 
Comment on attachment 43875 [details]
Patch

Clearing flags on attachment: 43875

Committed r51400: <http://trac.webkit.org/changeset/51400>
Comment 4 WebKit Commit Bot 2009-11-25 16:44:54 PST 
All reviewed patches have been landed.  Closing bug.