Bug 31864 - [GTK] use gst_init_check() instead of gst_init()
Summary: [GTK] use gst_init_check() instead of gst_init()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-25 01:51 PST by Philippe Normand
Modified: 2009-11-25 07:59 PST (History)
1 user (show)

See Also:


Attachments
Use gst_init_check() instead of gst_init() to prevent eventual unexpected exit of the application (2.63 KB, patch)
2009-11-25 02:11 PST, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2009-11-25 01:51:22 PST
During initialization of the GStreamer player we call gst_init() but this function can call exit(1) if something went wrong. I don't think we want that :) So we should use gst_init_check() which returns a boolean stating success or not of the GStreamer framework initialization.
Comment 1 Philippe Normand 2009-11-25 02:11:37 PST
Created attachment 43833 [details]
Use gst_init_check() instead of gst_init() to prevent eventual unexpected exit of the application

To prevent eventual unexpected exit of the application.
Comment 2 Eric Seidel (no email) 2009-11-25 07:47:28 PST
Comment on attachment 43833 [details]
Use gst_init_check() instead of gst_init() to prevent eventual unexpected exit of the application

Looks right to me.  cq+ too since Philippe is not in committers.py.
Comment 3 WebKit Commit Bot 2009-11-25 07:59:14 PST
Comment on attachment 43833 [details]
Use gst_init_check() instead of gst_init() to prevent eventual unexpected exit of the application

Clearing flags on attachment: 43833

Committed r51382: <http://trac.webkit.org/changeset/51382>
Comment 4 WebKit Commit Bot 2009-11-25 07:59:19 PST
All reviewed patches have been landed.  Closing bug.