RESOLVED FIXED 31864
[GTK] use gst_init_check() instead of gst_init() 
https://bugs.webkit.org/show_bug.cgi?id=31864
Summary [GTK] use gst_init_check() instead of gst_init()
Philippe Normand
Reported 2009-11-25 01:51:22 PST
During initialization of the GStreamer player we call gst_init() but this function can call exit(1) if something went wrong. I don't think we want that :) So we should use gst_init_check() which returns a boolean stating success or not of the GStreamer framework initialization.
Attachments
Use gst_init_check() instead of gst_init() to prevent eventual unexpected exit of the application (2.63 KB, patch)
2009-11-25 02:11 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2009-11-25 02:11:37 PST
Created attachment 43833 [details] Use gst_init_check() instead of gst_init() to prevent eventual unexpected exit of the application To prevent eventual unexpected exit of the application.
Eric Seidel (no email)
Comment 2 2009-11-25 07:47:28 PST
Comment on attachment 43833 [details] Use gst_init_check() instead of gst_init() to prevent eventual unexpected exit of the application Looks right to me. cq+ too since Philippe is not in committers.py.
WebKit Commit Bot
Comment 3 2009-11-25 07:59:14 PST
Comment on attachment 43833 [details] Use gst_init_check() instead of gst_init() to prevent eventual unexpected exit of the application Clearing flags on attachment: 43833 Committed r51382: <http://trac.webkit.org/changeset/51382>
WebKit Commit Bot
Comment 4 2009-11-25 07:59:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.