Bug 31861 – Update pywebsocket to 0.4.2

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Yuzo Fujishima]

Update pywebsocket to 0.4.2 (http://code.google.com/p/pywebsocket/).

In the new version a few bugs have been fixed, including one for https://bugs.webkit.org/show_bug.cgi?id=31603 (already fixed in the WebKit copy).
Also, the new version has better logging, which is needed for https://bugs.webkit.org/show_bug.cgi?id=31604

[Yuzo Fujishima]

Created attachment 43830 [details]
Update pywebsocket to 0.4.2

[Eric Seidel (no email)]

Comment on attachment 43830 [details]
Update pywebsocket to 0.4.2

LGTM too, but it look slike the new files are missing.  Was this uploaded by 'bugzilla-tool post-diff' or post-commits?  Those should both use --binary and correctly include new files.

[Yuzo Fujishima]

Created attachment 43883 [details]
Update pywebsocket to 0.4.2

[Yuzo Fujishima]

Created attachment 43884 [details]
Update pywebsocket to 0.4.2

[Yuzo Fujishima]

Hi, thank you for the review.

The file permission for the .py files were 755 for the first patch.
That might have caused the commit issue?

I've changed the permission to 644, which is the same as that of the files
already in the repository.

(I used bugzilla-tool  post-commits.
bugzilla-tool help post-commits/post-diff doesn't show --binary
option and bugzilla-tool actually rejected the option for me. So I haven't
used it.)

Yuzo

[Eric Seidel (no email)]

Comment on attachment 43884 [details]
Update pywebsocket to 0.4.2

I think I was simply confused.  I'm not sure there was any issue w/ the first patch.

[WebKit Commit Bot]

Comment on attachment 43884 [details]
Update pywebsocket to 0.4.2

Clearing flags on attachment: 43884

Committed r51406: <http://trac.webkit.org/changeset/51406>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.