Bug 31858 – fast/replaced/table-percent-height.html depends on form control sizes in Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Kent Tamura]

I think we had better modify table-percent-height.html so that it doesn't use
concrete pixel numbers. I don't think form controls in non-Mac platforms should
have the same dimensions as in Mac.

The current tests are like:

  shouldBe("getComputedStyleForElement(document.getElementById('button-75'),
'height')", "'15px'");
  shouldBe("getComputedStyleForElement(document.getElementById('button-100'),
'height')", "'15px'");

This should be changed to:

  shouldBe("getComputedStyleForElement(document.getElementById('button-75'),
           "getComputedStyleForElement(document.getElementById('button-100'));

[Kent Tamura]

Created attachment 43829 [details]
Proposed patch

See Bug#15359 for the origin of these tests.

[Adam Barth]

style-queue ran check-webkit-style on attachment 43829 [details] without any errors.

[Darin Adler]

Comment on attachment 43829 [details]
Proposed patch

If we really wanted to improve portability we'd change the test to not write out actual pixel sizes, right? I still see lots of pixel sizes written out.

This change seems fine, but I'm not really sure it achieves you goals.

[Kent Tamura]

(In reply to comment #3)
> (From update of attachment 43829 [details])
> If we really wanted to improve portability we'd change the test to not write
> out actual pixel sizes, right? I still see lots of pixel sizes written out.
> 
> This change seems fine, but I'm not really sure it achieves you goals.

Thank you for reviewing.
The remaining pixel values are for canvas, embed, and images.  We expect they have no platform differences, and we don't need to avoid pixel values.

[WebKit Commit Bot]

Comment on attachment 43829 [details]
Proposed patch

Clearing flags on attachment: 43829

Committed r51744: <http://trac.webkit.org/changeset/51744>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Kent Tamura]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 43829 [details] [details])
> > If we really wanted to improve portability we'd change the test to not write
> > out actual pixel sizes, right? I still see lots of pixel sizes written out.
> > 
> > This change seems fine, but I'm not really sure it achieves you goals.
> 
> Thank you for reviewing.
> The remaining pixel values are for canvas, embed, and images.  We expect they
> have no platform differences, and we don't need to avoid pixel values.

Ah, I found the test results had actual pixel sizes for button/input/select.  They should not be visible.