Bug 31851 – [Qt] QWebInspector unusable on certain window managers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Holger Freyther]

Created attachment 43811 [details]
Call setVisible from within the closeEvent

QWebInspector::hideEvent will call setVisible on the InspectorController disabling/resetting certain views. E.g. on ion3 the hide event is called when switching windows... so when going back to the QWebView every information is gone..

The code could be changed to call it from within the closeEvent. This should work for many usecases and in the worse case data of the InspectorController is held in memory a bit longer.

For binary compability reasons I'm leaving an empty ::hideEvent in the code...

[Adam Barth]

style-queue successfully ran check-webkit-style on attachment 43811 [details] without any errors

[Simon Hausmann]

Comment on attachment 43811 [details]
Call setVisible from within the closeEvent

I think the patch is correct.

Holger, do you think it's worth including in Qt 4.6.1? (in which case we need to cherry-pick a version that uses ::event() instead)

Jocelyn, any thoughts? :)

[Holger Freyther]

(In reply to comment #2)
> (From update of attachment 43811 [details])
> I think the patch is correct.
> 
> Holger, do you think it's worth including in Qt 4.6.1? (in which case we need
> to cherry-pick a version that uses ::event() instead)

Yes, without this the web inspector is completely useless on ion3...

> 
> Jocelyn, any thoughts? :)

[Jocelyn Turcotte]

yep, I agree!

[Holger Freyther]

Landed in r52144.

[Holger Freyther]

Created attachment 44856 [details]
Backport for 4.6

backport for the 4.6 branch

[Simon Hausmann]

(In reply to comment #6)
> Created an attachment (id=44856) [details]
> Backport for 4.6
> 
> backport for the 4.6 branch

Thanks!

Pushed into qtwebkit-4.6 as f1c562daf7b4d784cb9f386e47fc132e0843321f