Bug 31851 - [Qt] QWebInspector unusable on certain window managers
Summary: [Qt] QWebInspector unusable on certain window managers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-24 14:50 PST by Holger Freyther
Modified: 2009-12-15 03:16 PST (History)
3 users (show)

See Also:


Attachments
Call setVisible from within the closeEvent (2.62 KB, patch)
2009-11-24 14:50 PST, Holger Freyther
hausmann: review+
Details | Formatted Diff | Diff
Backport for 4.6 (2.40 KB, patch)
2009-12-15 02:43 PST, Holger Freyther
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2009-11-24 14:50:40 PST
Created attachment 43811 [details]
Call setVisible from within the closeEvent

QWebInspector::hideEvent will call setVisible on the InspectorController disabling/resetting certain views. E.g. on ion3 the hide event is called when switching windows... so when going back to the QWebView every information is gone..

The code could be changed to call it from within the closeEvent. This should work for many usecases and in the worse case data of the InspectorController is held in memory a bit longer.

For binary compability reasons I'm leaving an empty ::hideEvent in the code...
Comment 1 Adam Barth 2009-11-30 12:38:21 PST
style-queue successfully ran check-webkit-style on attachment 43811 [details] without any errors
Comment 2 Simon Hausmann 2009-12-04 15:21:36 PST
Comment on attachment 43811 [details]
Call setVisible from within the closeEvent

I think the patch is correct.

Holger, do you think it's worth including in Qt 4.6.1? (in which case we need to cherry-pick a version that uses ::event() instead)

Jocelyn, any thoughts? :)
Comment 3 Holger Freyther 2009-12-04 21:56:49 PST
(In reply to comment #2)
> (From update of attachment 43811 [details])
> I think the patch is correct.
> 
> Holger, do you think it's worth including in Qt 4.6.1? (in which case we need
> to cherry-pick a version that uses ::event() instead)

Yes, without this the web inspector is completely useless on ion3...

> 
> Jocelyn, any thoughts? :)
Comment 4 Jocelyn Turcotte 2009-12-06 05:06:57 PST
yep, I agree!
Comment 5 Holger Freyther 2009-12-15 01:31:30 PST
Landed in r52144.
Comment 6 Holger Freyther 2009-12-15 02:43:34 PST
Created attachment 44856 [details]
Backport for 4.6

backport for the 4.6 branch
Comment 7 Simon Hausmann 2009-12-15 03:03:27 PST
(In reply to comment #6)
> Created an attachment (id=44856) [details]
> Backport for 4.6
> 
> backport for the 4.6 branch

Thanks!

Pushed into qtwebkit-4.6 as f1c562daf7b4d784cb9f386e47fc132e0843321f