Created attachment 43807 [details] Provide an implementation Provide a Qt implementation for the above method. The current limit inside the Qt framework is six connections per host (and three in the pipeline).
Why "must this match"? I agree it probably should, I'm just confused by the comment.
You are right. There is no must. I will post an updated patch.
Created attachment 44225 [details] Provide a Qt specific implementation Slight improvement of the comment. I probably need to do some grammar and spelling fixes in one more round.
style-queue ran check-webkit-style on attachment 44225 [details] without any errors.
Comment on attachment 44225 [details] Provide a Qt specific implementation r=me
Comment on attachment 44225 [details] Provide a Qt specific implementation Rejecting patch 44225 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Simon Hausmann', '--force']" exit_code: 1 Last 500 characters of output: m/network/qt/ResourceRequestQt.cpp | 16 +++++++++++++++- 3 files changed, 34 insertions(+), 2 deletions(-) ------------------------------------------------------------------- patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/platform/network/ResourceRequestBase.cpp Hunk #1 FAILED at 378. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/platform/network/ResourceRequestBase.cpp.rej patching file WebCore/platform/network/qt/ResourceRequestQt.cpp
I waited for Dimitri to respond to my response. If Dimitri thinks there should be more work done we can reopen the bug again, for now closing is the most easy way to make it drop out of the review queue.
Okay, this was on the wrong bug. I will land this change in a second.. so there is no need to reopen it.
Landed in r52079.
This negatively interfers with HTTP pipelining in QNetworkAccessManager. I've sent a mail to the qtwebkit dev list.