WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
31848
Remove uses of mainThreadCurrentWorld, and of currentWorld using a globalData.
https://bugs.webkit.org/show_bug.cgi?id=31848
Summary
Remove uses of mainThreadCurrentWorld, and of currentWorld using a globalData.
Gavin Barraclough
Reported
2009-11-24 14:35:54 PST
These methods get the world from the global data rather than from an execstate. If the current world is always read from an exec state then it can be read from the global object, and world entry can become automagical, rather than being explicitly set by an EnterDOMWrapperWorld.
Attachments
The patch
(20.52 KB, patch)
2009-11-24 14:37 PST
,
Gavin Barraclough
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gavin Barraclough
Comment 1
2009-11-24 14:37:41 PST
Created
attachment 43808
[details]
The patch
Geoffrey Garen
Comment 2
2009-11-24 14:58:28 PST
Comment on
attachment 43808
[details]
The patch hasCachedDOMObjectWrapper can just call contains, rather than get.
Gavin Barraclough
Comment 3
2009-11-24 15:43:32 PST
Sending WebCore/ChangeLog Sending WebCore/bindings/js/JSCSSRuleCustom.cpp Sending WebCore/bindings/js/JSCSSValueCustom.cpp Sending WebCore/bindings/js/JSDOMBinding.cpp Sending WebCore/bindings/js/JSDOMBinding.h Sending WebCore/bindings/js/JSDOMWindowCustom.cpp Sending WebCore/bindings/js/JSDocumentCustom.cpp Sending WebCore/bindings/js/JSElementCustom.cpp Sending WebCore/bindings/js/JSEventCustom.cpp Sending WebCore/bindings/js/JSHTMLCollectionCustom.cpp Sending WebCore/bindings/js/JSImageDataCustom.cpp Sending WebCore/bindings/js/JSNodeCustom.cpp Sending WebCore/bindings/js/JSSVGPathSegCustom.cpp Sending WebCore/bindings/js/JSStyleSheetCustom.cpp Sending WebCore/xml/XMLHttpRequest.cpp Transmitting file data ............... Committed revision 51363.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug