Bug 31845 - queries_unittest.py should test command output
Summary: queries_unittest.py should test command output
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-24 12:07 PST by Eric Seidel (no email)
Modified: 2009-11-24 15:19 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.17 KB, patch)
2009-11-24 12:14 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-11-24 12:07:49 PST 
queries_unittest.py should test command output

Right now we only test to make sure that the commands can be executed w/o throwing an exception.  Lets test to make sure the commands actually output as expected too.
Comment 1 Eric Seidel (no email) 2009-11-24 12:14:38 PST 
Created attachment 43797 [details]
Patch
Comment 2 Adam Barth 2009-11-24 13:43:13 PST 
Comment on attachment 43797 [details]
Patch

This is great!  We'll eventually want to factor that functionality in a base class so other tests can make use of it, but we can cross that bridge when we come to it.
Comment 3 WebKit Commit Bot 2009-11-24 15:19:35 PST 
Comment on attachment 43797 [details]
Patch

Clearing flags on attachment: 43797

Committed r51362: <http://trac.webkit.org/changeset/51362>
Comment 4 WebKit Commit Bot 2009-11-24 15:19:40 PST 
All reviewed patches have been landed.  Closing bug.