WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
31845
queries_unittest.py should test command output
https://bugs.webkit.org/show_bug.cgi?id=31845
Summary
queries_unittest.py should test command output
Eric Seidel (no email)
Reported
2009-11-24 12:07:49 PST
queries_unittest.py should test command output Right now we only test to make sure that the commands can be executed w/o throwing an exception. Lets test to make sure the commands actually output as expected too.
Attachments
Patch
(3.17 KB, patch)
2009-11-24 12:14 PST
,
Eric Seidel (no email)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2009-11-24 12:14:38 PST
Created
attachment 43797
[details]
Patch
Adam Barth
Comment 2
2009-11-24 13:43:13 PST
Comment on
attachment 43797
[details]
Patch This is great! We'll eventually want to factor that functionality in a base class so other tests can make use of it, but we can cross that bridge when we come to it.
WebKit Commit Bot
Comment 3
2009-11-24 15:19:35 PST
Comment on
attachment 43797
[details]
Patch Clearing flags on attachment: 43797 Committed
r51362
: <
http://trac.webkit.org/changeset/51362
>
WebKit Commit Bot
Comment 4
2009-11-24 15:19:40 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug