Start/stop events are generated in dispatchDidChangeLocationWithinPage for WebView delegate. Currently they are generated regardless whether a frame is is loading or not. This causes nested start/stop events being fired when dispatchDidChangeLocationWithinPage happens from a fragment redirect in window.onloader handler. Attached patch makes the start/stop events only being fired when the page's main frame has stopped loading to avoid such situation.
Created attachment 43780 [details] Proposed patch.
Comment on attachment 43780 [details] Proposed patch. > Index: third_party/WebKit/WebKit/chromium/src/FrameLoaderClientImpl.cpp ... > + // Flag of whether frame loader is completed. Generate didStartLoading and > + // didStopLoading only when loader is completed so that we don't fire > + // them for fragment redirection that happens in window.onload handler. > + // See http://crbug.com/15782 nit: please link to the bugs.webkit.org bug instead. that bug can have a reference to the chromium bug if you think it would be helpful. also, you need to include a modification to WebCore/ChangeLog. please see the instructions here: http://webkit.org/coding/contributing.html
Created attachment 43800 [details] updated per Darin's comments - Added ChangeLog using prepare-ChangeLog; - Update bug link per suggestion;
Created attachment 43801 [details] remove scm.py change Remove my local scm.py change that accidentally gets into the previous diff.
Comment on attachment 43801 [details] remove scm.py change R=me, but please remember to set the '?' on the review flag in the future. Otherwise, reviewers may never notice your patch!
Comment on attachment 43801 [details] remove scm.py change Rejecting patch 43801 from commit-queue. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html
Comment on attachment 43801 [details] remove scm.py change Is it because my diff is from git?
Comment on attachment 43801 [details] remove scm.py change I have no idea why the cq failed here. Let's spin again and see if it fails a second time. If it does, then I'll try to debug why.
Created attachment 44030 [details] update patch Previous patch is rejected by commit-queue bot because my base ChangeLog is too old and the bot failed to patc. I have updated the patch and hopefully it works this time. Thanks.
style-queue ran check-webkit-style on attachment 44030 [details] without any errors.
Comment on attachment 44030 [details] update patch Clearing flags on attachment: 44030 Committed r51548: <http://trac.webkit.org/changeset/51548>
All reviewed patches have been landed. Closing bug.