[Android] The select elements do not reflect the actual choice the user makes.

[Andrei Popescu]

<select multiple="multiple"> elements always show the first of the available choices instead of the first item that was actually selected by the user.

[Andrei Popescu]

Created attachment 43846 [details]
Handle the drawing of ListBoxes in Android code. Also fix exisiting style issues.

[Dimitri Glazkov (Google)]

Comment on attachment 43846 [details]
Handle the drawing of ListBoxes in Android code. Also fix exisiting style issues.

Thanks for cleaning up the old code!

r=me, except:

>  bool RenderThemeAndroid::paintTextArea(RenderObject* obj, const RenderObject::PaintInfo& info, const IntRect& rect)
>  {
> -    if (obj->isMenuList())
> -        return paintCombo(obj, info, rect);
> +    if (obj->isListBox()) {
> +        paintCombo(obj, info, rect);

Can this be just an early return?

[Ben Murdoch]

(In reply to comment #2)
> (From update of attachment 43846 [details])
> Thanks for cleaning up the old code!
> 
> r=me, except:
> 
> >  bool RenderThemeAndroid::paintTextArea(RenderObject* obj, const RenderObject::PaintInfo& info, const IntRect& rect)
> >  {
> > -    if (obj->isMenuList())
> > -        return paintCombo(obj, info, rect);
> > +    if (obj->isListBox()) {
> > +        paintCombo(obj, info, rect);
> 
> Can this be just an early return?

I can make this change on landing.

[Ben Murdoch]

Landed as r51386.