Bug 31814 - Inconsistent use of counterName and identifier in CSS counter code and loss of information about the counter type.
Summary: Inconsistent use of counterName and identifier in CSS counter code and loss o...
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Carol Szabo
Depends on: 31723
Blocks: 11031
  Show dependency treegraph
Reported: 2009-11-23 15:57 PST by Carol Szabo
Modified: 2009-12-21 12:12 PST (History)
3 users (show)

See Also:

Proposed Patch (10.98 KB, patch)
2009-12-09 18:11 PST, Carol Szabo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carol Szabo 2009-11-23 15:57:06 PST
Patch coming soon.
Comment 1 Carol Szabo 2009-12-09 18:11:30 PST
Created attachment 44587 [details]
Proposed Patch

Added accessors and members to the CounterNode class to differentiate between reset type nodes and nodes that act as reset because they are not in the scope of any other counter node with the same identifier. This is useful in reevaluating the values of counters when new counters are added to the DOM that may make a root node non-root.
Changed references to counterName to identifier for consistency.
Comment 2 WebKit Review Bot 2009-12-09 18:14:53 PST
style-queue ran check-webkit-style on attachment 44587 [details] without any errors.
Comment 3 Darin Adler 2009-12-21 12:03:42 PST
Comment on attachment 44587 [details]
Proposed Patch

> +    // identifier must match the identifier of this counter.
>      void removeChild(CounterNode*, const AtomicString& identifier);

The comment here is worded strangely. You say it must match. That makes it sound like it's a programming mistake if I pass an identifier that does not match. I don't think that's how it works.

Maybe this wording: "Does nothing unless the identifier matches the identifier of the counter."

Or maybe you can think of something better.

Comment 4 WebKit Commit Bot 2009-12-21 12:11:55 PST
Comment on attachment 44587 [details]
Proposed Patch

Clearing flags on attachment: 44587

Committed r52450: <http://trac.webkit.org/changeset/52450>
Comment 5 WebKit Commit Bot 2009-12-21 12:12:00 PST
All reviewed patches have been landed.  Closing bug.