Bug 31811 - Accidental calls to EventNames() instead of eventNames() waste CPU cycles
Summary: Accidental calls to EventNames() instead of eventNames() waste CPU cycles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Minor
Assignee: Jens Alfke
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2009-11-23 12:53 PST by Jens Alfke
Modified: 2009-11-23 14:26 PST (History)
0 users

See Also:

Attachments
patch (5.19 KB, patch)
2009-11-23 14:16 PST, Jens Alfke 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Alfke 2009-11-23 12:53:28 PST 
I just discovered five places in WebCore that accidentally call EventNames() when they mean eventNames(). The end result of the call will be the same, but the mistaken call is a constructor that creates about 100 AtomicString instances every time it's called.
Comment 1 Jens Alfke 2009-11-23 14:16:21 PST 
Created attachment 43734 [details]
patch
Comment 2 Geoffrey Garen 2009-11-23 14:20:02 PST 
Comment on attachment 43734 [details]
patch

r=me
Comment 3 Jens Alfke 2009-11-23 14:26:02 PST 
Committed revision 51321.