Bug 31810 - [Android] Android port requires platform-specific implementation of initializeMaximumHTTPConnectionCountPerHost
Summary: [Android] Android port requires platform-specific implementation of initializ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-23 10:45 PST by Steve Block
Modified: 2009-12-11 10:24 PST (History)
10 users (show)

See Also:

Attachments
Patch 1 for Bug 31810 (3.57 KB, patch)
2009-11-23 10:57 PST, Steve Block 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2009-11-23 10:45:33 PST 
Android port requires platform-specific implementation of initializeMaximumHTTPConnectionCountPerHost.
Comment 1 Steve Block 2009-11-23 10:57:12 PST 
Created attachment 43720 [details]
Patch 1 for Bug 31810
Comment 2 Eric Seidel (no email) 2009-11-23 20:05:44 PST 
I thought the point of this default was less about what the loader was capable of, and more about "being a good web citizen" or something.  Donno.  I'm not an expert here.
Comment 3 Steve Block 2009-11-25 09:38:28 PST 
(In reply to comment #2)
> I thought the point of this default was less about what the loader was capable
> of, and more about "being a good web citizen" or something.  Donno.  I'm not an
> expert here.
The comment in loader.cpp for maxRequestsInFlightPerHost, and the comment in ResourceRequestBase.cpp for initializeMaximumHTTPConnectionCountPerHost both seem to suggest that the objective of this limit is to match the capability of the network layer.

Can you point me to an expert who can confirm the intended use?
Comment 4 Eric Seidel (no email) 2009-11-25 09:42:04 PST 
Maciej or Bradey should know.
Comment 5 Adam Barth 2009-11-30 12:36:37 PST 
style-queue successfully ran check-webkit-style on attachment 43720 [details] without any errors
Comment 6 Darin Fisher (:fishd, Google) 2009-12-11 10:06:08 PST 
Comment on attachment 43720 [details]
Patch 1 for Bug 31810

This patch is fine.  Given such a high limit on connection counts per host, you
might also consider disabling the REQUEST_MANAGEMENT_ENABLED define in loader.cpp.
Comment 7 WebKit Commit Bot 2009-12-11 10:24:50 PST 
Comment on attachment 43720 [details]
Patch 1 for Bug 31810

Clearing flags on attachment: 43720

Committed r52005: <http://trac.webkit.org/changeset/52005>
Comment 8 WebKit Commit Bot 2009-12-11 10:24:55 PST 
All reviewed patches have been landed.  Closing bug.