WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
31808
createShader() needs better param checking
https://bugs.webkit.org/show_bug.cgi?id=31808
Summary
createShader() needs better param checking
Chris Marrin
Reported
2009-11-23 09:52:57 PST
it will accept any non-FRAGMENT_SHADER value as GL_VERTEX_SHADER
Attachments
Patch including test
(5.51 KB, patch)
2009-11-24 10:05 PST
,
Chris Marrin
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Marrin
Comment 1
2009-11-24 10:05:40 PST
Created
attachment 43779
[details]
Patch including test
Eric Seidel (no email)
Comment 2
2009-11-24 10:42:44 PST
Comment on
attachment 43779
[details]
Patch including test Looks good, but maybe NOT_SUPPORTED_ERR would be better?
Chris Marrin
Comment 3
2009-11-24 17:57:35 PST
We need to revisit the whole exception model of WebGL. For now we have been using SYNTAX_ERR for bad params, so I'll leave it at that for now.
Chris Marrin
Comment 4
2009-11-24 19:13:42 PST
Landed in
http://trac.webkit.org/changeset/51370
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug