Bug 31808 - createShader() needs better param checking
Summary: createShader() needs better param checking
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Chris Marrin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-23 09:52 PST by Chris Marrin
Modified: 2009-11-24 19:13 PST (History)
3 users (show)

See Also:

Attachments
Patch including test (5.51 KB, patch)
2009-11-24 10:05 PST, Chris Marrin 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2009-11-23 09:52:57 PST 
it will accept any non-FRAGMENT_SHADER value as GL_VERTEX_SHADER
Comment 1 Chris Marrin 2009-11-24 10:05:40 PST 
Created attachment 43779 [details]
Patch including test
Comment 2 Eric Seidel (no email) 2009-11-24 10:42:44 PST 
Comment on attachment 43779 [details]
Patch including test

Looks good, but maybe NOT_SUPPORTED_ERR would be better?
Comment 3 Chris Marrin 2009-11-24 17:57:35 PST 
We need to revisit the whole exception model of WebGL. For now we have been using SYNTAX_ERR for bad params, so I'll leave it at that for now.
Comment 4 Chris Marrin 2009-11-24 19:13:42 PST 
Landed in http://trac.webkit.org/changeset/51370