Bug 31807 - [Android] Android port lacks platform-specific WTF thread functions
Summary: [Android] Android port lacks platform-specific WTF thread functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-23 08:44 PST by Steve Block
Modified: 2009-11-25 09:48 PST (History)
5 users (show)

See Also:


Attachments
Patch 1 for Bug 31807 (2.76 KB, patch)
2009-11-23 08:54 PST, Steve Block
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2009-11-23 08:44:17 PST
Android port lacks platform-specific WTF thread functions
- initializeMainThreadPlatform()
- scheduleDispatchFunctionsOnMainThread()
Comment 1 Steve Block 2009-11-23 08:54:37 PST
Created attachment 43718 [details]
Patch 1 for Bug 31807
Comment 2 Dmitry Titov 2009-11-23 12:06:33 PST
Comment on attachment 43718 [details]
Patch 1 for Bug 31807

r=me.

> +using namespace android;
This seems not needed and can be removed on landing...
Comment 3 Steve Block 2009-11-23 14:38:38 PST
> > +using namespace android;
> This seems not needed and can be removed on landing...
JavaSharedClient will be added to WebKit/android and uses namespace android.
Comment 4 WebKit Commit Bot 2009-11-23 14:55:30 PST
Comment on attachment 43718 [details]
Patch 1 for Bug 31807

Clearing flags on attachment: 43718

Committed r51323: <http://trac.webkit.org/changeset/51323>
Comment 5 WebKit Commit Bot 2009-11-23 14:55:35 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Alexey Proskuryakov 2009-11-23 15:52:16 PST
Should we delete Android-specific code from ThreadingPthreads.cpp now? I can't wait to get rid of layering violations in runThreadWithRegistration().
Comment 7 Steve Block 2009-11-25 09:48:34 PST
(In reply to comment #6)
> Should we delete Android-specific code from ThreadingPthreads.cpp now? I can't
> wait to get rid of layering violations in runThreadWithRegistration().
No, I'm afraid this is still required.