Bug 31794 - [Qt] Mac Plugins : Get Input Events to work in QGV
Summary: [Qt] Mac Plugins : Get Input Events to work in QGV
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Girish Ramakrishnan
URL:
Keywords: Qt
Depends on: 31183
Blocks:
  Show dependency treegraph
 
Reported: 2009-11-22 21:07 PST by Girish Ramakrishnan
Modified: 2009-11-26 05:19 PST (History)
8 users (show)

See Also:


Attachments
Plugin events (ideal) (973 bytes, patch)
2009-11-23 06:08 PST, Girish Ramakrishnan
no flags Details | Formatted Diff | Diff
Plugin events (reality) (2.58 KB, patch)
2009-11-23 06:09 PST, Girish Ramakrishnan
no flags Details | Formatted Diff | Diff
Pass mouse position relative to the fake window (2.14 KB, patch)
2009-11-25 04:58 PST, Girish Ramakrishnan
no flags Details | Formatted Diff | Diff
Pass activeWindow() to make Flash process mouse move events (4.81 KB, patch)
2009-11-25 05:01 PST, Girish Ramakrishnan
hausmann: review+
Details | Formatted Diff | Diff
Make mouse over work without using active window (3.28 KB, patch)
2009-11-26 02:33 PST, Girish Ramakrishnan
zecke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Girish Ramakrishnan 2009-11-22 21:07:27 PST
Rendering was fixed in 31183. Events are still not getting delivered correctly.
Comment 1 Girish Ramakrishnan 2009-11-23 06:08:28 PST
Created attachment 43709 [details]
Plugin events (ideal)

This is how plugin events should work ideally.
Comment 2 Girish Ramakrishnan 2009-11-23 06:09:36 PST
Created attachment 43710 [details]
Plugin events (reality)

Flash requires the window that we pass to be the active window. So, an extremely ugly patch to please flash.
Comment 3 Girish Ramakrishnan 2009-11-25 04:58:22 PST
Created attachment 43836 [details]
Pass mouse position relative to the fake window
Comment 4 Girish Ramakrishnan 2009-11-25 05:01:11 PST
Created attachment 43837 [details]
Pass activeWindow() to make Flash process mouse move events

I did not add a plugin quirk (PluginQuirkRequiresActiveWindowForInputEvents) because there is a bug in the Mac port - PluginPackage::determineQuirks is never called. Also, the plugin quirk seems to complicate the code a bit. So, what about leaving it out for now?
Comment 5 Simon Hausmann 2009-11-25 05:49:00 PST
Comment on attachment 43837 [details]
Pass activeWindow() to make Flash process mouse move events

r=me, but a quirk would be nice to have in the future.
Comment 6 Girish Ramakrishnan 2009-11-26 02:33:13 PST
Created attachment 43911 [details]
Make mouse over work without using active window

Ok, I have figured out a way to make events work without using QApplication::activeWindow().
Comment 7 Girish Ramakrishnan 2009-11-26 05:05:46 PST
Landed in r51412
Comment 8 Girish Ramakrishnan 2009-11-26 05:06:41 PST
Comment on attachment 43911 [details]
Make mouse over work without using active window

Clear r?
Comment 9 Holger Freyther 2009-11-26 05:19:22 PST
Comment on attachment 43911 [details]
Make mouse over work without using active window

Just for the record... I r=me'd on irc..