You need to
before you can comment on or make changes to this bug.
Found a few places where config.h is not included as it is described in the style guide - http://webkit.org/coding/coding-style.html.
Note that there are a few places (e.g. API tests for WebKit public API, *AllInOne*.cpp etc) where config.h is obviously not needed. This patch does not add config.h to those files.
Created an attachment (id=43691) [details]
(From update of attachment 43691 [details])
That's a lot of files without config.h!
I'm worried about changes to some Windows files - seems that definitions in WebKitDLL.h might be necessary to compile subsequent headers - e.g. WebScriptObject.h. Did you verify that the Windows port builds with these changes?
Alexey, thanks for looking into this.
I just verified that the (Safari) Windows port builds with these changes. It looks to me that quite many .cpp files under WebKit/win have the same include order (e.g. WebSecurityOrigin.cpp).
Then I'm all for this patch! Let's hope things go well, so please watch the bot after you commit.
Landed as http://trac.webkit.org/changeset/51336.