Bug 31789 - Web Inspector: Introduce sidebar background on timeline panel in order to prevent it from flickering on scroll.
Summary: Web Inspector: Introduce sidebar background on timeline panel in order to pre...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-22 11:53 PST by Pavel Feldman
Modified: 2009-11-22 12:06 PST (History)
4 users (show)

See Also:


Attachments
[PATCH] proposed fix (5.47 KB, patch)
2009-11-22 11:55 PST, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-11-22 11:53:48 PST
Will attach patch shortly.
Comment 1 Pavel Feldman 2009-11-22 11:55:52 PST
Created attachment 43685 [details]
[PATCH] proposed fix
Comment 2 Timothy Hatcher 2009-11-22 11:58:41 PST
Comment on attachment 43685 [details]
[PATCH] proposed fix


> -            this._refreshTimeout = setTimeout(this._refresh.bind(this), 100);
> +            this._refreshTimeout = setTimeout(this._refresh.bind(this), immediate ? 0 : 100);

A 0 delay timeout isn't immediate, it will be 10ms in Safari.

That matter?
Comment 3 Pavel Feldman 2009-11-22 12:04:26 PST
(In reply to comment #2)
> (From update of attachment 43685 [details])
> 
> > -            this._refreshTimeout = setTimeout(this._refresh.bind(this), 100);
> > +            this._refreshTimeout = setTimeout(this._refresh.bind(this), immediate ? 0 : 100);
> 
> A 0 delay timeout isn't immediate, it will be 10ms in Safari.
> 
> That matter?

Not really, I just don't want to wait extra 100ms on scroll since I know i need to redraw and there is no need in coalescing. As a result, 100ms coalescing is only there for window resize (to make it real smooth) and for adding entries (for obvious reasons). Note that I can't invoke refresh on scroller synchronously since it would break the scroller smoothness. Anyway, I think 10ms is good.
Comment 4 Pavel Feldman 2009-11-22 12:06:06 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/TimelinePanel.js
	M	WebCore/inspector/front-end/inspector.css
Committed r51297