Bug 31767 - commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
Summary: commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-21 07:01 PST by Eric Seidel (no email)
Modified: 2009-11-21 07:50 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.72 KB, patch)
2009-11-21 07:05 PST, Eric Seidel (no email) 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-11-21 07:01:55 PST 
commit-queue fails to run with "permissions error" due to bad bugzilla-tool path

When we moved the queue commands into queues.py, an important __file__ definition came with, and now the commit-queue is trying to exec queues.py instead of bugzilla-tool when launching land-attachment for the commit-queue.

I couldn't think of a useful unit test for this. What we really want to test is that BugzillaToo.path() points to an executable script.  However we don't have any way to unit test BugzillaTool itself yet.
Comment 1 Eric Seidel (no email) 2009-11-21 07:05:13 PST 
Created attachment 43647 [details]
Patch
Comment 2 Adam Barth 2009-11-21 07:28:16 PST 
Comment on attachment 43647 [details]
Patch

Yep.  My bad
Comment 3 Eric Seidel (no email) 2009-11-21 07:50:38 PST 
Committed r51283: <http://trac.webkit.org/changeset/51283>