Bug 31747 - Chromium Linux: Limit the stroke width and mitre limit
Summary: Chromium Linux: Limit the stroke width and mitre limit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-20 14:39 PST by Adam Langley
Modified: 2009-11-23 14:13 PST (History)
1 user (show)

See Also:

Attachments
patch (2.18 KB, patch)
2009-11-20 14:40 PST, Adam Langley 		no flags Details | Formatted Diff | Diff
patch (2.35 KB, patch)
2009-11-23 11:32 PST, Adam Langley 		dimich: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Langley 2009-11-20 14:39:15 PST 
Chromium Linux: Limit the stroke width and mitre limit that we'll pass into Skia to avoid overflowing Skia's uint16_t glyph widths.
Comment 1 Adam Langley 2009-11-20 14:40:54 PST 
Created attachment 43614 [details]
patch
Comment 2 Dmitry Titov 2009-11-20 22:16:05 PST 
It'd be useful to document in the bug and/or comment why did you use 512 and 256. If this is a random choice, that's fine but it's useful to put it in writing so the next person reading the code does not have to guess if there is some magic meaning behind those. Or if there is magic meaning, it's even more useful to document :-)
Comment 3 Adam Langley 2009-11-23 11:32:48 PST 
Created attachment 43723 [details]
patch

Good point about the comment. Have added one.
Comment 4 Dmitry Titov 2009-11-23 11:57:52 PST 
Comment on attachment 43723 [details]
patch

r=me
Comment 5 Adam Langley 2009-11-23 14:13:53 PST 
r51319