ASSIGNED31740
New Bug Attachment + Patch checkbox does not show contribution terms 
https://bugs.webkit.org/show_bug.cgi?id=31740
Summary New Bug Attachment + Patch checkbox does not show contribution terms
William Siegrist
Reported 2009-11-20 13:17:09 PST
When you attach a patch to a bug, some contribution terms are supposed to appear. The terms need to appear on the page when the Patch checkbox is checked. It works on the attachment page at <https://bugs.webkit.org/attachment.cgi?bugid=3564&action=enter>. It does not work when attaching during the initial filing of a bug <https://bugs.webkit.org/enter_bug.cgi?product=WebKit>.
Attachments
Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2009-11-20 14:48:51 PST
It seems like we have a similar issue with other methods of submitting patches (eg, via bugzilla-tool).
Alexey Proskuryakov
Comment 2 2009-11-20 15:56:44 PST
One can't reasonably upload patches when creating a bug, because bug number is needed to write a ChangeLog.
David Kilzer (:ddkilzer)
Comment 3 2009-11-20 17:50:24 PST
(In reply to comment #1) > It seems like we have a similar issue with other methods of submitting patches > (eg, via bugzilla-tool). I filed Bug 31757 for bugzilla-tool. (In reply to comment #2) > One can't reasonably upload patches when creating a bug, because bug number is > needed to write a ChangeLog. I've wanted to use a place-holder for the bug number in the ChangeLog, then make the various tools (bugzilla-tool, etc.) smart enough to do the replacement when the patch was applied. People could still post an initial patch for review without a ChangeLog if they just wanted feedback as well.
William Siegrist
Comment 4 2009-11-20 19:03:22 PST
(In reply to comment #2) > One can't reasonably upload patches when creating a bug, because bug number is > needed to write a ChangeLog. The terms govern submission of code to the WebKit project in general. So even if there is no way the project would accept the submission, there should still be terms on the submission page. Ideally, the terms should be shown to anyone, using any method or tool, for anything that is intended to possibly land in the repository. But this bug is obviously just asking to cover the bugzilla form(s). I suppose another option is to disable the patch attachment functionality in the new bug form if the project really wants to discourage that.
Alexey Proskuryakov
Comment 5 2009-11-20 22:07:40 PST
> I suppose another option is to disable the patch attachment functionality in > the new bug form if the project really wants to discourage that. Yes, that's precisely what I've been talking about. Given David's comment above, this may not be the best option.
Note You need to log in before you can comment on or make changes to this bug.