Bug 31738 – Web Inspector: Console Scope Bar should be on top of console when Console is a Panel

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Brian Weinstein]

Created attachment 43604 [details]
Screenshot 1

Console Scope Bar should be on top of console to match other scope bars.

[Brian Weinstein]

Created attachment 43605 [details]
Screenshot 2

[Pavel Feldman]

Screenshot 1 looks good, but Screenshot 2 does not. I think we should leave things as is for drawer version of console. I wonder what happens to animation then...

[Brian Weinstein]

Created attachment 43606 [details]
[PATCH] Fix

[Timothy Hatcher]

Comment on attachment 43606 [details]
[PATCH] Fix

We should not have the scope bar on top in drawer mode. It is hwere it is to save vertical space. I agree, it should be on top in panel mode though.

[Brian Weinstein]

Created attachment 44575 [details]
Scope Bar On Bottom

[Brian Weinstein]

Created attachment 44576 [details]
Scope Bar On Top

[Brian Weinstein]

Created attachment 44577 [details]
[PATCH] Fix

Screenshots are with this patch applied.

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 44577 [details] without any errors.

[Pavel Feldman]

Comment on attachment 44577 [details]
[PATCH] Fix

> +        // Update styles, and give coneole-messages a top margin so it doesn't overwrite the scope bar.

coneole-messages -> console-messages

> +        scopeBar.addStyleClass("console-filter-top");
> +        document.getElementById("console-messages").style.marginTop = "23px";

xenon usually wants numbers to be a part of css

[Timothy Hatcher]

(In reply to comment #9)
> > +        scopeBar.addStyleClass("console-filter-top");
> > +        document.getElementById("console-messages").style.marginTop = "23px";
> 
> xenon usually wants numbers to be a part of css

Yes this should be done by adding/removing a class name.

[Brian Weinstein]

Landed in r51952.