Bug 31738 - Web Inspector: Console Scope Bar should be on top of console when Console is a Panel
Summary: Web Inspector: Console Scope Bar should be on top of console when Console is ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Weinstein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-20 12:38 PST by Brian Weinstein
Modified: 2009-12-10 10:59 PST (History)
8 users (show)

See Also:

Attachments
Screenshot 1 (89.06 KB, image/png)
2009-11-20 12:38 PST, Brian Weinstein 		no flags Details
Screenshot 2 (117.47 KB, image/png)
2009-11-20 12:39 PST, Brian Weinstein 		no flags Details
[PATCH] Fix (3.68 KB, patch)
2009-11-20 12:44 PST, Brian Weinstein 		timothy: review-
bweinstein: commit-queue-
Details | Formatted Diff | Diff
Scope Bar On Bottom (187.16 KB, image/png)
2009-12-09 15:59 PST, Brian Weinstein 		no flags Details
Scope Bar On Top (76.95 KB, image/png)
2009-12-09 15:59 PST, Brian Weinstein 		no flags Details
[PATCH] Fix (3.44 KB, patch)
2009-12-09 16:04 PST, Brian Weinstein 		pfeldman: review+
bweinstein: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Weinstein 2009-11-20 12:38:48 PST 
Created attachment 43604 [details]
Screenshot 1

Console Scope Bar should be on top of console to match other scope bars.
Comment 1 Brian Weinstein 2009-11-20 12:39:29 PST 
Created attachment 43605 [details]
Screenshot 2
Comment 2 Pavel Feldman 2009-11-20 12:43:46 PST 
Screenshot 1 looks good, but Screenshot 2 does not. I think we should leave things as is for drawer version of console. I wonder what happens to animation then...
Comment 3 Brian Weinstein 2009-11-20 12:44:43 PST 
Created attachment 43606 [details]
[PATCH] Fix
Comment 4 Timothy Hatcher 2009-11-20 13:11:20 PST 
Comment on attachment 43606 [details]
[PATCH] Fix

We should not have the scope bar on top in drawer mode. It is hwere it is to save vertical space. I agree, it should be on top in panel mode though.
Comment 5 Brian Weinstein 2009-12-09 15:59:29 PST 
Created attachment 44575 [details]
Scope Bar On Bottom
Comment 6 Brian Weinstein 2009-12-09 15:59:54 PST 
Created attachment 44576 [details]
Scope Bar On Top
Comment 7 Brian Weinstein 2009-12-09 16:04:39 PST 
Created attachment 44577 [details]
[PATCH] Fix

Screenshots are with this patch applied.
Comment 8 WebKit Review Bot 2009-12-09 16:05:39 PST 
style-queue ran check-webkit-style on attachment 44577 [details] without any errors.
Comment 9 Pavel Feldman 2009-12-10 10:25:12 PST 
Comment on attachment 44577 [details]
[PATCH] Fix

> +        // Update styles, and give coneole-messages a top margin so it doesn't overwrite the scope bar.

coneole-messages -> console-messages

> +        scopeBar.addStyleClass("console-filter-top");
> +        document.getElementById("console-messages").style.marginTop = "23px";

xenon usually wants numbers to be a part of css
Comment 10 Timothy Hatcher 2009-12-10 10:43:21 PST 
(In reply to comment #9)
> > +        scopeBar.addStyleClass("console-filter-top");
> > +        document.getElementById("console-messages").style.marginTop = "23px";
> 
> xenon usually wants numbers to be a part of css

Yes this should be done by adding/removing a class name.
Comment 11 Brian Weinstein 2009-12-10 10:59:21 PST 
Landed in r51952.